ci(families): add isolation review guardrails - #2
Closed
chaofengw-nv wants to merge 2 commits into
Closed
Conversation
Run each selected family E2E from a temporary source root containing only the shared build contracts and its owning family. Keep the existing runtime DSO isolation so sibling imports, file reads, links, and symlinks fail during the real proof. Teach automated reviews that cross-family duplication is intentional, and cover both policies with source-quality tests. Signed-off-by: chaofengw <chaofengw@nvidia.com>
Give CodeRabbit a repository-wide review contract and advisory checks for family ownership, shared semantic neutrality, benchmark validation integrity, and shared-change blast radius. Re-run reviews on every push and focus shared-path comments on evidence-backed behavior. Keep the checks in warning mode while their signal is calibrated, and preserve the policy with source-quality regression tests. Signed-off-by: chaofengw <chaofengw@nvidia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
PR NVIDIA/TensorRT-Model-Connect#1093 makes the model family the unit of ownership and fault isolation. Static architecture checks catch direct source dependencies, but they cannot prove runtime/source independence or consistently identify semantic family coupling introduced through shared tooling, benchmarks, examples, and validation code.
Exit Criteria
Implementation
core/builder, root test configuration, and the owning family. Reject family symlinks and disable user-site imports so sibling imports and file reuse fail at execution time.libtrtmc_model_<family>.so.REVIEW.mdas the repository-wide Standards/Spec review contract for automated and human reviewers.PASS,BLOCK, orHUMAN REVIEW REQUIRED.Validation
ruff check --config ruff.toml tools/ci/context.py tools/ci/process.py tools/ci/e2e.py tools/tests/test_new_ci.py: passed.PYTHONPATH=core/builder:apps/benchmark:. python3 -m pytest tools/tests/test_new_ci.py -q: 26 passed.CI_BASE_REF=github/pr/1093 PYTHONPATH=core/builder:apps/benchmark:. python3 -m tools.ci pipeline source-quality: 107 passed on head960389b955e5c4b822efec1121e075e6bfd333f1.PYTHONPATH=core/builder:apps/benchmark:. python3 -m pytest -q -m "not gpu and not trt" -p no:cacheprovider: 339 passed, 274 skipped, 5 deselected on the same head..coderabbit.yamlvalidated against the current CodeRabbit v2 JSON schema.Notes For Future Readers
agent/ai-native-horizontal-scalebefore refactor: isolate model families end to end NVIDIA/TensorRT-Model-Connect#1093, or be rebased ontomainafter refactor: isolate model families end to end NVIDIA/TensorRT-Model-Connect#1093 merges.REVIEW.mdand.coderabbit.yamlfirst, thentools/ci/e2e.py, followed by the regression tests.warningmode withrequest_changes_workflow: false. Promote a check toerroronly after real-PR calibration demonstrates acceptable signal.