Repository navigation
fix(extension): cancelled runs say 'cancelled', not that an extension failed - #262
Merged
Merged
Conversation
…as cancelled The result stays withheld (a redactor may not have run), but the text no longer reads as an extension failure. Test with a failing-hook control, mutation-checked. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01T7iq5hpndSiHQcnAsywKuG
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up from #261's review. On a cancelled run with an extension installed, a tool result whose
after_toolwas cut off by the cancel read "Tool result withheld: extension 'x' did not finish processing it." — which looks like the extension failed.The result is still withheld (a redactor may not have run, so letting the raw output through would be unsafe); only the text changes, to "Tool result withheld: the run was cancelled before extension 'x' finished processing it." A real failure keeps the old text.
Test: an
after_toolthat waits until cancel → the new text; control: a failingafter_toolkeeps "did not finish processing it". Mutation-checked (fails with the old text).🤖 Generated with Claude Code
https://claude.ai/code/session_01T7iq5hpndSiHQcnAsywKuG