Repository navigation
fix(tools): list_files reports paths find couldn't read (#260) - #263
Merged
Merged
Conversation
find's stderr and exit status were ignored, so an unreadable subdirectory silently vanished from a listing reported as complete. The listed files are returned with the errors under Warnings and in details.warnings (capped); an error with no files fails, as search does. Test (mutation-checked) with a readable-tree control; skips when permissions aren't enforced (root). Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01T7iq5hpndSiHQcnAsywKuG
…test restores permissions on panic Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01T7iq5hpndSiHQcnAsywKuG
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #260 (found by yoyo).
list_filesranfindwith stderr piped but never read stderr or the exit status, so an unreadable subdirectory (e.g.chmod 000) silently disappeared and the listing read as complete.Now, the same shape as
search(#235):finddid list are returned, with its errors appended underWarnings (some paths could not be read; the listing may be incomplete)and indetails.warnings(capped at 2000 chars;nullwhen clean);Listing error: …).Test: a temp tree with a readable file and a
chmod 000subdirectory → the readable file is listed, warnings present in text and details; control: the readable tree haswarnings: null. Skips (with a message) when permissions aren't enforced (running as root). Mutation-checked: fails against the old code.Docs: tools reference, CLAUDE.md, CHANGELOG.
🤖 Generated with Claude Code
https://claude.ai/code/session_01T7iq5hpndSiHQcnAsywKuG