Repository navigation
test(rutis): fix flaky handler-name uniqueness test - #266
Merged
Merged
Conversation
The test read both rows' failures from the reconcile report, but reconcile settles only rows already starting: a row whose runtime is still coming up counts as settled. On CI the report once held only the Python row's failure. Poll each row's status (up to 60 s) instead. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01T7iq5hpndSiHQcnAsywKuG
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01T7iq5hpndSiHQcnAsywKuG
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
languages_test::handler_names_are_unique_across_languagesread both rows' failures from thereconcilereport.reconcileonly waits for rows already starting; a row whose runtime is still coming up counts as settled. On CI (PR #265's run) the report once held only the Python row's failure, so the test failed although the bridge behaved correctly.The test now polls each row's status (
Loader::get) until both have failed, up to 60 s, then checks the error text.cargo test --features node,python --test languages_testwithYOAGENT_RUTIS_REQUIRE_RUNTIMES=1: 11 passed.Test-only change.
🤖 Generated with Claude Code
https://claude.ai/code/session_01T7iq5hpndSiHQcnAsywKuG