Repository navigation
fix(tooling): bound host timing JSON nesting independently of the decoder - #1330
Merged
yyjeqhc merged 1 commit intoOct 28, 2026
Merged
Conversation
yyjeqhc
approved these changes
Oct 28, 2026
yyjeqhc
left a comment
Owner
There was a problem hiding this comment.
Reviewed the iterative 128-depth bound, the inclusive array/object boundary cases, and error/size behavior. The patch is focused; CI and the diff check are green.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Host timing input JSON is byte-bounded, but its nesting limit currently depends on whether the Python decoder raises a recursion error. A valid document with 129 levels is accepted by
_read_bounded_json, despite the bounded-input contract.Add an iterative depth check with an inclusive limit of 128 after decoding. Keep the existing 64 KiB read limit and static
invalid input JSONerror. Regression subtests cover arrays and objects at depths 128 (accepted) and 129 (rejected).Validation on Python 3.14.8, based on upstream
7cf6442f:python3 -m unittest scripts.tests.test_host_timing_dogfood: 14 passed on exact head4454a138.git diff --check: passed.This change touches only the timing-report parser and its tests.