Repository navigation
test(cli): isolate controller fixture command lookup - #1333
Merged
yyjeqhc merged 1 commit intoOct 28, 2026
Merged
Conversation
The controller TUI fixture inherited the test process PATH, which other tests replace, so its external utility lookups failed non-deterministically. Pin a child-local PATH for the spawned shell and cover it with an isolated child-process regression that runs the fixture with a polluted inherited PATH.
yyjeqhc
approved these changes
Oct 28, 2026
yyjeqhc
left a comment
Owner
There was a problem hiding this comment.
Reviewed the scoped implementation and regression coverage against its source baseline; CI and diff checks pass. No blocking issue identified.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
controller_tuitest fixtures run scripts through/bin/sh. The child inherited the test process's globalPATH, and other tests in this binary legitimately replace that process-global environment. When a concurrently running test had rewrittenPATH, the fixture's external utility lookups failed non-deterministically (observed assleep: command not found), producing failures unrelated to the behavior under test.Change
The fixture now sets a child-local
PATH(/usr/bin:/bin) on the spawned shell instead of inheriting the process environment. This is test-only: no production code, CLI behavior, or global environment is modified.The regression runs the fixture in an isolated child process whose inherited
PATHcontains no shell utilities. The fixture's own script calls an external utility (sleep), so the child process can only succeed when the command lookup is child-local. The parent test asserts the isolated probe actually ran and passed, so a filter that matches nothing cannot report a false success.Scope: POSIX only, matching the existing fixture (
/bin/sh,#[cfg(unix)]). The fixture already requires a POSIX layout; pinning the two standard system directories does not assume Nix or Homebrew layouts.Validation
The ignored probe is invoked explicitly by its parent test; it is not meant to run in the ordinary parallel pool. Not run here: macOS and Windows lanes (no environment available; the fixture is POSIX-only by construction).