Skip to content

implement robust multi-permission handling for local scan #166

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
fooqman wants to merge 1 commit into
base: main
Choose a base branch
from
Open

implement robust multi-permission handling for local scan #166

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
151 changes: 148 additions & 3 deletions app/src/main/java/com/zalexdev/stryker/localnetwork/LocalMain.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,15 +1,20 @@
package com.zalexdev.stryker.localnetwork;

import android.Manifest;
import android.app.Activity;
import android.app.Dialog;
import android.content.Context;
import android.content.Intent;
import android.content.pm.PackageManager;
import android.graphics.Color;
import android.graphics.drawable.ColorDrawable;
import android.net.ConnectivityManager;
import android.net.DhcpInfo;
import android.net.NetworkInfo;
import android.net.Uri;
import android.net.wifi.WifiInfo;
import android.net.wifi.WifiManager;
import android.os.Build;
import android.os.Bundle;
import android.view.LayoutInflater;
import android.view.View;
Expand All @@ -19,6 +24,10 @@
import android.widget.LinearLayout;
import android.widget.TextView;

import androidx.activity.result.ActivityResultLauncher;
import androidx.activity.result.contract.ActivityResultContracts;
import androidx.annotation.NonNull;
import androidx.core.app.ActivityCompat;
import androidx.fragment.app.Fragment;
import androidx.recyclerview.widget.LinearLayoutManager;
import androidx.recyclerview.widget.RecyclerView;
Expand All @@ -38,8 +47,10 @@
import com.zalexdev.stryker.utils.Core;

import java.util.ArrayList;
import java.util.List;
import java.util.Locale;
import java.util.concurrent.atomic.AtomicBoolean;
import java.util.function.BiConsumer;

public class LocalMain extends Fragment {

Expand All @@ -65,6 +76,7 @@ public class LocalMain extends Fragment {
public MaterialTextView networkGateway;
public MaterialTextView networkSubnet;
public MaterialTextView networkCount;
private MaterialButton warningButton;
public MaterialButton rescanBtn;

private RecyclerView mRecyclerView;
Expand All @@ -78,6 +90,14 @@ public class LocalMain extends Fragment {
private final AtomicBoolean alive = new AtomicBoolean(true);

private AdvancedLocalScanner scanner;
private ActivityResultLauncher<String[]> multiplePermissionsLauncher;
private BiConsumer<Boolean, Boolean> multipleCallback;
private String[] currentPermissionsGroup;
private final String[] REQUIRED_PERMISSIONS = new String[]{
Manifest.permission.ACCESS_FINE_LOCATION,
Manifest.permission.ACCESS_COARSE_LOCATION,
Build.VERSION.SDK_INT >= Build.VERSION_CODES.TIRAMISU ? Manifest.permission.NEARBY_WIFI_DEVICES : null
};

public LocalMain() {
}
Expand All @@ -86,6 +106,31 @@ private boolean uiSafe() {
return alive.get() && activity != null && isAdded();
}

@Override
public void onCreate(Bundle savedInstanceState) {
super.onCreate(savedInstanceState);
multiplePermissionsLauncher = registerForActivityResult(
new ActivityResultContracts.RequestMultiplePermissions(),
result -> {
if (multipleCallback == null || currentPermissionsGroup == null) return;

boolean allGranted = true;
boolean anyNeverAskAgain = false;

for (String permission : currentPermissionsGroup) {
Boolean isGranted = result.get(permission);
if (isGranted == null || !isGranted) {
allGranted = false;
if (!ActivityCompat.shouldShowRequestPermissionRationale(requireActivity(), permission)) {
anyNeverAskAgain = true;
}
}
}
multipleCallback.accept(allGranted, anyNeverAskAgain);
}
);
}

@Override
public View onCreateView(LayoutInflater inflater, ViewGroup container, Bundle savedInstanceState) {
View view = inflater.inflate(R.layout.local_fragment, container, false);
Expand All @@ -106,6 +151,7 @@ public View onCreateView(LayoutInflater inflater, ViewGroup container, Bundle sa
getResources().getColor(R.color.stryker_accent),
0xFFAB47BC);
refresh.setOnRefreshListener(this::triggerScan);
warningButton.setOnClickListener(v -> showMissingPermissionsDialog(true));
rescanBtn.setOnClickListener(v -> triggerScan());

View statusRow = view.findViewById(R.id.local_status_row);
Expand Down Expand Up @@ -152,6 +198,24 @@ public void onViewCreated(View view, Bundle savedInstanceState) {
}
}

@Override
public void onResume() {
super.onResume();
List<String> missingPermissions = new ArrayList<>();

for (String perm : getActualRequiredPermissions()) {
if (ActivityCompat.checkSelfPermission(requireContext(), perm) != PackageManager.PERMISSION_GRANTED) {
missingPermissions.add(perm);
}
}

if (missingPermissions.isEmpty()) {
warningButton.setVisibility(View.GONE);
} else {
warningButton.setVisibility(View.VISIBLE);
}
}

private void reloadDevicesFromPersistentSource() {
ArrayList<Device> restored = null;
if (mainActivity != null && mainActivity.getDevices() != null
Expand Down Expand Up @@ -189,6 +253,7 @@ private void bindViews(View view) {
networkGateway = view.findViewById(R.id.network_gateway);
networkSubnet = view.findViewById(R.id.network_subnet);
networkCount = view.findViewById(R.id.network_count);
warningButton = view.findViewById(R.id.warning_button);
rescanBtn = view.findViewById(R.id.network_rescan);
}

Expand Down Expand Up @@ -216,10 +281,90 @@ private void triggerScan() {
startScan();
}

public void startScan() {
if (core != null && !core.hasLocationPermission()) {
core.requestLocationPermission(activity);
private void openAppSettings() {
Intent intent = new Intent(android.provider.Settings.ACTION_APPLICATION_DETAILS_SETTINGS);
intent.setData(
Uri.fromParts(
"package", requireContext().getPackageName(), null));
startActivity(intent);
}

@NonNull
private List<String> getActualRequiredPermissions() {
List<String> actual = new ArrayList<>();
for (String perm : REQUIRED_PERMISSIONS) {
if (perm != null) actual.add(perm);
}
return actual;
}

private void showMissingPermissionsDialog(boolean asWarning) {
List<String> missingPermissions = new ArrayList<>();

for (String perm : getActualRequiredPermissions()) {
if (ActivityCompat.checkSelfPermission(requireContext(), perm) != PackageManager.PERMISSION_GRANTED) {
String shortName = perm.substring(perm.lastIndexOf(".") + 1);
missingPermissions.add("«" + shortName + "»");
}
}

if (missingPermissions.isEmpty()) return;

String missingText = String.join(", ", missingPermissions);

String message = String.format(getString(R.string.local_scan_permissions_desc), missingText);

MaterialAlertDialogBuilder dialog = new MaterialAlertDialogBuilder(requireContext())
.setTitle(getString(R.string.warning))
.setMessage(message);
dialog.setCancelable(false);
if (asWarning) {
dialog.setPositiveButton(getString(R.string.ok), null);
} else {
dialog.setPositiveButton(android.R.string.ok, (d, w) -> _startScan());
}
dialog.setNeutralButton(getString(R.string.settings), (d, w) -> openAppSettings());
if (!asWarning)
dialog.setNegativeButton(getString(R.string.cancel), null);
dialog.show();
}

private void checkMultiplePermissions(@NonNull String[] permissions, BiConsumer<Boolean, Boolean> callback) {
boolean allGranted = true;
for (String permission : permissions) {
if (ActivityCompat.checkSelfPermission(requireContext(), permission) != PackageManager.PERMISSION_GRANTED) {
allGranted = false;
break;
}
}

if (allGranted) {
callback.accept(true, false);
return;
}

this.currentPermissionsGroup = permissions;
this.multipleCallback = callback;
multiplePermissionsLauncher.launch(permissions);
}

public void startScan() {
String[] permissionsArray = getActualRequiredPermissions().toArray(new String[0]);

checkMultiplePermissions(permissionsArray, (isAllGranted, isNeverAskAgain) -> {
if (isAllGranted) {
warningButton.setVisibility(View.GONE);
_startScan();
} else if (isNeverAskAgain) {
warningButton.setVisibility(View.VISIBLE);
_startScan();
} else {
showMissingPermissionsDialog(false);
}
});
}

private void _startScan() {
if (scanner != null) {
try {
scanner.stopScan();
Expand Down
42 changes: 0 additions & 42 deletions app/src/main/java/com/zalexdev/stryker/utils/Core.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,9 +6,7 @@
import static android.os.Build.VERSION.SDK_INT;
import static android.os.Environment.getExternalStorageDirectory;

import android.annotation.SuppressLint;
import android.app.Activity;
import android.app.Dialog;
import android.content.ActivityNotFoundException;
import android.content.ClipData;
import android.content.ClipboardManager;
Expand All @@ -20,13 +18,10 @@
import android.content.pm.PackageManager;
import android.database.Cursor;
import android.database.sqlite.SQLiteDatabase;
import android.graphics.Color;
import android.graphics.drawable.ColorDrawable;
import android.net.Uri;
import android.net.wifi.WifiConfiguration;
import android.net.wifi.WifiManager;
import android.os.Build;
import android.os.Bundle;
import android.os.Handler;
import android.os.Looper;
import android.os.VibrationEffect;
Expand All @@ -35,22 +30,17 @@
import android.text.TextUtils;
import android.text.format.Formatter;
import android.view.View;
import android.widget.LinearLayout;
import android.widget.TextView;
import android.widget.Toast;

import androidx.annotation.NonNull;
import androidx.cardview.widget.CardView;
import androidx.core.app.ActivityCompat;
import androidx.core.content.FileProvider;
import androidx.security.crypto.EncryptedSharedPreferences;
import androidx.security.crypto.MasterKeys;
import androidx.viewpager.widget.ViewPager;
import androidx.viewpager2.widget.ViewPager2;

import com.google.android.material.switchmaterial.SwitchMaterial;
import com.zalexdev.stryker.BuildConfig;
import com.zalexdev.stryker.R;
import com.zalexdev.stryker.custom.Credentials;
import com.zalexdev.stryker.custom.Device;
import com.zalexdev.stryker.custom.Exploit;
Expand All @@ -63,19 +53,16 @@
import com.zalexdev.stryker.logger.LogTool;
import com.zalexdev.stryker.logger.Logger;

import org.json.JSONArray;
import org.json.JSONException;
import org.json.JSONObject;

import java.io.BufferedReader;
import java.io.File;
import java.io.FileNotFoundException;
import java.io.FileOutputStream;
import java.io.IOException;
import java.io.InputStream;
import java.io.InputStreamReader;
import java.io.OutputStream;
import java.io.OutputStreamWriter;
import java.net.HttpURLConnection;
import java.net.URI;
import java.security.GeneralSecurityException;
Expand All @@ -86,7 +73,6 @@
import java.util.HashSet;
import java.util.LinkedHashSet;
import java.util.Locale;
import java.util.Objects;
import java.util.UUID;
import com.stryker.terminal.bridge.StrykerLog;

Expand Down Expand Up @@ -1442,34 +1428,6 @@ public void checkPermission(Activity activity) {
}
}

public boolean hasLocationPermission() {
try {
return context.checkSelfPermission(android.Manifest.permission.ACCESS_FINE_LOCATION)
== PackageManager.PERMISSION_GRANTED;
} catch (Exception e) {
return false;
}
}

public void requestLocationPermission(Activity activity) {
if (activity == null) return;
try {
ArrayList<String> wanted = new ArrayList<>();
if (!hasLocationPermission()) {
wanted.add(android.Manifest.permission.ACCESS_FINE_LOCATION);
wanted.add(android.Manifest.permission.ACCESS_COARSE_LOCATION);
}
if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.TIRAMISU
&& context.checkSelfPermission(android.Manifest.permission.NEARBY_WIFI_DEVICES)
!= PackageManager.PERMISSION_GRANTED) {
wanted.add(android.Manifest.permission.NEARBY_WIFI_DEVICES);
}
if (wanted.isEmpty()) return;
ActivityCompat.requestPermissions(activity, wanted.toArray(new String[0]), 124);
} catch (Exception ignored) {
}
}

public void requestAllFilesAccess(Activity activity) {
try {
if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.R) {
Expand Down
Loading