Repository navigation
Parse current OnlineHashCrack API response format - #95
Merged
Merged
Conversation
The OHC upload API no longer returns a success boolean + message; it
responds with accepted/skipped/rejected count objects (e.g.
{\accepted\:{\count\:1,...},\skipped\:0,\rejected\:0}).
parseUploadResult() matched none of that, so a successful upload was
reported to the user as a failure with an empty message.
Recognize the new format (accepted>0 = success, skipped>0 = already
sent, otherwise rejected reason) while keeping the legacy success-flag
path for older responses.
zalexdev
added a commit
that referenced
this pull request
Oct 3, 2026
Two files needed hands; the rest merged as-is. RootlessEngine: #101 added chipsetDriverHint() in the same place the dialogs refactor put the javadoc and @OverRide on usb(). Both kept. WiFIAdapter, handshake attack: took our side, which no longer declares the `clients` list the refactor removed, plus #92's !isInternalDeauthEnabled() guard. WiFIAdapter, type 7: #92 patched the old outputtext version of this block, which our side had already rewritten against AttackMonitor. Reapplied the intent -- the internal radio is refused only while the toggle is off, and the refusal now names the setting instead of claiming the hardware cannot inject.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The upload parser expects a response format OnlineHashCrack no longer
uses, so successful uploads are reported as failures.
From the app's debug log DB on a test device, a real upload response:
The upload itself succeeded (accepted count 1, the hash landed in the
user's OHC dashboard) — but parseUploadResult() only recognizes the
legacy {"success":true,"message":...} shape. It matched nothing, fell
through every branch, and the app toasted a generic upload-failed
message with no detail.
Recognize the current format in the JSON branch:
The legacy success-flag path is kept for older/other response shapes,
and the non-JSON text fallbacks (already/success/uploaded keywords)
are unchanged.