feat(nav): wallet sits in the bottom row like every other tab - #745
Merged
Merged
Conversation
The center cell was a raised, bar-colored disc carrying the bolt logo. That shape means "compose" or "primary action" in the apps this bar is meant to match, and it opens the wallet — so it was making a promise the button doesn't keep, in the one spot the eye goes first. It is now an ordinary tab with the same Wallet icon the nav menu and the desktop side nav use, on the same baseline as its four neighbours and switching to the filled weight when the wallet is open, exactly as the other tabs do on active. The disc's absolute positioning, its 56px geometry, its bar-colored fill and its press-scale all existed only to make that one button float, so they go with it. Behavior is unchanged: the same openWallet/closeWallet toggle behind the same label.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brings the mobile bottom bar closer to the native apps.
The center cell was a raised, bar-colored disc carrying the bolt logo, lifting above the bar's top edge and floating over the scrolling content. That shape means compose or primary action in the apps this bar is meant to match — and it opens the wallet, so it was making a promise the button doesn't keep, in the one spot the eye goes first.
It's now an ordinary tab: the same
Walleticon the nav menu and the desktop side nav already use, on the same baseline as its four neighbours, switching to the filled weight when the wallet is open exactly as the other tabs do on active.The disc's absolute positioning, its 56px geometry, its bar-colored fill and its press-scale existed only to make that one button float, so they go with it — +15/−48 in one file.
Behavior is unchanged: the same
openWallet/closeWallettoggle behind the samearia-label.Testing
At 390px, all five tabs now sit on one baseline — flame, fork-and-knife, wallet, envelope, bell — with no raised disc left in the DOM.
svelte-checkunchanged from main, build clean.The active state is unverified. Clicking the wallet tab signed out does nothing, but the drawer's existing wallet entry behaves identically, so that's the wallet being a signed-in feature rather than anything this changes. Worth a glance while signed in that the icon fills and tints while the wallet is open.
ZapCookingIconnow has no callers. Left in place rather than deleted, in case it's wanted elsewhere.