Skip to content

Fix test debug locator #44

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lejmr wants to merge 2 commits into
base: main
Choose a base branch
from
+9 −12
Open

Fix test debug locator #44

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d714750
fix: parse the binary path emitted by the test build task
lejmr Aug 5, 2026
8e74235
fix: strip quotes from the --test-filter argument
lejmr Aug 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 9 additions & 12 deletions src/zig.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -200,8 +200,10 @@ impl zed::Extension for ZigExtension {
let mut args: Vec<String> = build_task
.args
.into_iter()
// TODO verify if this is required on non-Windows platforms
.map(|s| s.replace("\"", "'"))
// The build task is spawned without a shell, so the quotes around
// $ZED_CUSTOM_ZIG_TEST_NAME reach --test-filter literally and match
// no test at all. Drop them; each arg is already one argv element.
.map(|s| s.replace('"', ""))
.collect();
args.push("--test-no-exec".into());
args.push(format!("-femit-bin={test_exe_path}"));
Expand Down Expand Up @@ -266,19 +268,14 @@ impl zed::Extension for ZigExtension {
Ok(zed::DebugRequest::Launch(request))
}
Some(arg) if arg == "test" => {
// `strip_prefix` already yields the bare path, so the subsequent
// `split("=").nth(1)` was always `None` for paths without a `=`.
let program = build_task
.args
.iter()
.find_map(|arg| {
arg.strip_prefix("-femit-bin=").map(|arg| {
arg.split("=")
.nth(1)
.ok_or("Expected binary path in -femit-bin=")
.map(|path| path.trim_end_matches(".exe"))
})
})
.ok_or("Failed to extract binary path from command args")
.flatten()?
.find_map(|arg| arg.strip_prefix("-femit-bin="))
.ok_or("Failed to extract binary path from command args")?
.trim_end_matches(".exe")
.to_string();
let request = zed::LaunchRequest {
program,
Expand Down