Conversation
Default to False. It is never used in our projects and therefore not tested
get(), get_children() and _find_entity() rebuilt and deepcopy()'d the entire tree on every call. Cache the flattened views and an id->entity index, invalidating them on post()/update_one()/json_file reassignment. Rewrite tests/test_offline.py to fix tests that were silently broken: filterwarnings=["error"] turned intentional warnings into crashes, and a leftover YAML-era string assertion could never match JSON output. Tests now isolate file-writing cases to a private tmp_path copy instead of mutating the tracked fixture, and add coverage for the new caching behavior. Also add uv.lock for reproducible installs (with the check-manifest rule to include it), and document the new caching behavior in the README. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Code Coverage Report
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🚀 Pull Request: Merge
devintomain📋 Summary
This PR updates the CI/CD pipeline to use
uvandty, enables automated unit testing in CI, adds performance caching forOfflineFlexilims, and cleans up dead code and type annotations.⚡ Performance & Improvements
OfflineFlexilimsCaching: Added internal caching for tree lookup operations (get,get_children,_flat_data), significantly speeding up offline database operations on large datasets. Cache automatically invalidates on mutations (post,update_one, or updatingjson_file).🐛 Bug Fixes & Refactoring
parse_errornow safely returns raw server messages instead of raising anAttributeErrorwhen encountering non-HTML error responses.OfflineFlexilims._format_dataframemethod.tystatic analysis.🛠️ CI / CD & Tooling
znamlab/python-uv-cireusable workflow (uv-based installation, linting, andtytype checking).IOErrorguard intest_flexilims.py).mypywithtyfor local & CI consistency.uv buildfor wheels/sdist publishing.docs_build_and_deploy.ymlworkflow.