Add sort to private inventories - #1148
Merged
Merged
Conversation
TrickyLeifa
approved these changes
Aug 18, 2026
| foreach (QString evi, inventory.childGroups()) | ||
| QStringList sortedInventory = inventory.childGroups(); | ||
| std::sort(sortedInventory.begin(), sortedInventory.end(), [](const QString &a, const QString &b) { return a.toInt() < b.toInt(); }); | ||
| foreach (QString evi, sortedInventory) |
Contributor
There was a problem hiding this comment.
If I can suggest anything, don't use Qt's keywords. Just use the proper for loop rather than foreach.
// before
foreach (QString evi, sortedInventory)
// after
for (const QString &group : std::as_const(sortedInventory))
Contributor
Author
There was a problem hiding this comment.
This is better in general, though for this particular case, I would offer that it can pass as is.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a sort before loading. resolves #1086.