Skip to content

Add sort to private inventories #1148

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
WisoAltred merged 1 commit into from
Aug 18, 2026
Merged

Add sort to private inventories #1148

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/evidence.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -864,7 +864,9 @@ void Courtroom::evidence_load(QString filename)
inventory.setIniCodec("UTF-8");
#endif
private_evidence_list.clear();
foreach (QString evi, inventory.childGroups())
QStringList sortedInventory = inventory.childGroups();
std::sort(sortedInventory.begin(), sortedInventory.end(), [](const QString &a, const QString &b) { return a.toInt() < b.toInt(); });
foreach (QString evi, sortedInventory)

@TrickyLeifa TrickyLeifa Aug 18, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I can suggest anything, don't use Qt's keywords. Just use the proper for loop rather than foreach.

// before
foreach (QString evi, sortedInventory)

// after
for (const QString &group : std::as_const(sortedInventory))

@WisoAltred WisoAltred Aug 18, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is better in general, though for this particular case, I would offer that it can pass as is.

{
if (evi == "General")
{
Expand Down
Loading