Repository navigation
Themes: clip cells readable in any slot colour; audit reads color-mix; full CaYaDev change list (#770) - #774
Merged
Merged
Conversation
…; honest CaYaDev change list (#770) Measuring the Performance View, the Auto VJ conflict note, the lyric editor and the MCP setup in all seven themes found the clip cells the self-test had skipped. On a white slot the info line fell to 3.3:1 on hover (CaYaDev), the countdown to 3.5:1 in Light, and a sourceless slot's name to 3.3:1 under opacity. Slot tint is now 10% (12% on hover with a stronger border), countdowns use --warn-text, and the sourceless slot is dimmed with colour instead of opacity. The runtime audit parsed color(srgb ...) (the computed form of color-mix) as nothing and measured text against the card underneath. It now parses it and measures clip cells; only cells with a scene preview are skipped. A new test measures every text in a cell, in every state, on nine extreme slot colours, and the same-rule CSS pair test handles color-mix backgrounds. CHANGELOG and ROADMAP now list every visible CaYaDev change found by reading the old CSS. Test count 3223. Co-authored-by: caganturgut <271973834+caganturgut@users.noreply.github.com>
Co-authored-by: caganturgut <271973834+caganturgut@users.noreply.github.com>
|
CaYaDraft — pull request Summary Files
Note Stopping here. I will not merge, push, or change this pull request until you ask.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #771 (#770).
Why
After #771, four restyled surfaces had not been looked at:
I opened all four in all seven themes (isolated profile, a clip deck seeded with extreme slot colours) and ran the audit with clip cells included. Both the self-test and the static tests had missed the following.
Root causes:
.cd-celland.perf-cellbecause the slot colour is user content.color(srgb …), the computed form ofcolor-mix(), as nothing. Any such background was ignored and the text was measured against the card underneath.Changes
Cell tint.
.cd-cell.filledtint goes from 14% to 10%. On hover it goes from 22% to 12%, and the border goes to 75% to show the hover.Countdowns.
.cd-countand.perf-countuse--warn-text. They used--warnand--cue-armed, which are fill colours.Slot with no source.
.cd-cell.filled.norefhas a dashed border, no tint and--mutedtext, instead ofopacity: .65.Audit.
ui-contrast-audit.jsparsescolor(srgb r g b / a), in gradients too. SKIP now covers only cells with a scene preview:.cd-cell:has(> .cd-thumb)and.perf-cell:has(> .perf-thumb).Tests.
color-mix(in srgb, var(--a) N%, var(--b)). For--slotit uses nine extreme colours plus--slot-default.color(srgb …).Docs. CHANGELOG and ROADMAP now list every visible CaYaDev change, found by reading the pre-Interface themes: CaYaDev, Dark, Light, Device default, High Contrast and more (#770) #771 CSS:
The Interface themes: CaYaDev, Dark, Light, Device default, High Contrast and more (#770) #771 text said that only four colours had changed.
Verification
npm test: 3223 passed (+1).SVUiTheme.set, which a category switch reverts.--smokeon this head with an isolated profile and the seeded deck: PASS. About 2,680 texts per theme, none below the threshold. Lowest ratios: CaYaDev 4.54, Dark 4.54, Light 4.96, High Contrast 7.8, Midnight 4.54, Sepia 5.12, Neon 4.54.Not changed
Clip cells showing a scene preview put their text over a 40% picture of the scene's colours. That is content, so they stay out of the audit, as before.