Repository navigation
Themes: clip preview text on its own backing; selected scene row readable (#770) - #775
Merged
Merged
Conversation
…w readable (#770) Clip cells that show a scene preview or an image drew their texts over a 40% picture of user content: on a white scene the text was below 3:1, and .cd-meta was not positioned, so the preview was painted over it. The name, info line and countdown now sit on a --card backing, and the audit no longer skips any clip cell. Auditing every category with a populated profile (scenes, preview cells, a lyric file, open folds) found the selected scene's info line (--muted2 on accent-soft) at 3.90:1 in Light; the self-test loads its own settings without saved scenes and never saw it. That row uses --muted, and the rules now cover --text and --muted on --accent-rgb .16 (143 rules). Co-authored-by: caganturgut <271973834+caganturgut@users.noreply.github.com>
|
CaYaDraft — pull request Summary Files
Note Stopping here. I will not merge, push, or change this pull request until you ask.
|
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #774 (#770).
Clip cells with a preview
A clip cell that references a scene shows the scene's background colours at 40% behind the text. An image slot does the same with the image, and the Performance View at 32%. #774 left these cells out of the audit, because the text sits on user content.
Measured live with a white scene, a black scene, a white/yellow/cyan gradient and a white image:
.cd-metawas not positioned, so the absolutely positioned preview was painted over it.Fix
.cd-name,.cd-metaand a non-empty.cd-countsit on avar(--card)backing with a 4px radius, and so do theperf-equivalents. The preview stays visible around them..cd-metais nowposition: relative; z-index: 1like the name.The selected scene row
I ran the audit through every category in every theme, with a profile holding the scenes above, preview cells, a lyric file and every fold open. It found the selected scene's info line,
--muted2onaccent-soft, at 3.90:1 in Light. The same line was 4.1–4.4:1 in Midnight and CaYaDev.The self-test loads its own settings with no saved scenes, so it never drew this row.
.scene-item.active .scene-metauses--muted.--textand--mutedon--accent-rgb .16over bg2, card and card2 are now contrast rules, which brings the total to 143.Tests
.cd-name,.cd-metaand.perf-nameto be positioned above the preview.npm test: 3223 passed.Verification
--smokewith an isolated profile: PASS.