Name the shared broker in HispecDaemon and apply LIBBY_ environment overrides - #238
Merged
Merged
Conversation
mikelangmayr
force-pushed
the
mike/daemon-broker-url-and-env-overrides
branch
from
October 1, 2026 01:03
3a215aa to
0b0a9e4
Compare
prkrtg
approved these changes
Oct 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
rabbitmq_urlonHispecDaemonso the broker address is declared once instead of per daemon config; no deployed config sets it todayfrom_config_filetoenv_prefix="LIBBY_", soLIBBY_<KEY>variables override config keys; it was passed asNone, which readLIBBY_RABBITMQ_URLand silently ignored it/etc/hispec/secrets.envrather than a config file everyhispec-opsmember can readLIBBY_RABBITMQ_URLdeploy step under SecretsLIBBY_RABBITMQ_URLto/etc/hispec/secrets.envon each host before restarting daemons, since an off-host daemon cannot use guest and an on-host one no longer connects over loopbackACCESS_REFUSED, and withLIBBY_RABBITMQ_URLalone it serves all 25 keywords with no broker line in its YAML