Skip to content

Name the shared broker in HispecDaemon and apply LIBBY_ environment overrides #238

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mikelangmayr merged 1 commit into from
Oct 1, 2026
Merged

Name the shared broker in HispecDaemon and apply LIBBY_ environment overrides #238

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions docs/operations/systemd.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -211,6 +211,18 @@ the value never reaches git. For the PDU that is `hardware.username_env` and
variables. Inline `hardware.username` / `hardware.password` still work for a
bench test, but the daemon logs a warning against committing them.

Any top-level config key can also be replaced by a `LIBBY_<KEY>` variable,
which suits a value that is itself a secret. `HispecDaemon` names the broker
but holds no password, so every host supplies one:

```bash
sudo tee -a /etc/hispec/secrets.env <<'EOF'
LIBBY_RABBITMQ_URL=amqp://<user>:<password>@131.215.200.214
EOF
```

Without it a daemon is refused with `ACCESS_REFUSED ... mechanism PLAIN`.

## Troubleshooting

Start here:
Expand Down
14 changes: 14 additions & 0 deletions src/hispec/daemon.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,12 @@
"""Common base for the HISPEC daemons: transport, broker and config sources."""

from typing import Optional

from libby.daemon import LibbyDaemon

# The shared broker, on hispec-new; credentials come from LIBBY_RABBITMQ_URL
BROKER_URL = "amqp://131.215.200.214"


class HispecDaemon(LibbyDaemon):
"""Instantiates the HispecDaemon base using LibbyDaemon.
Expand All @@ -8,3 +15,10 @@ class HispecDaemon(LibbyDaemon):

transport = "rabbitmq"
discovery_enabled = False
rabbitmq_url = BROKER_URL

@classmethod
def from_config_file(cls, path: str, daemon_id: Optional[str] = None, *,
env_prefix: Optional[str] = "LIBBY_") -> "HispecDaemon":
"""Build a daemon, applying LIBBY_* environment overrides by default."""
return super().from_config_file(path, daemon_id, env_prefix=env_prefix)
Loading