Cape Town | 26-ITP-Sep | Sima Nongawuza | Sprint 1 | CYF-1004 - #1529
Open
simanongawuza wants to merge 8 commits into
Open
simanongawuza wants to merge 8 commits into
simanongawuza wants to merge 8 commits into
Conversation
✅ Deploy Preview for cyf-onboarding-module ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This comment has been minimized.
This comment has been minimized.
simanongawuza
changed the title
This comment has been minimized.
This comment has been minimized.
1 similar comment
This comment has been minimized.
This comment has been minimized.
simanongawuza
changed the title
This comment has been minimized.
This comment has been minimized.
Liam310
added
the
Needs Review
Luro91
added
the
Review in progress
Luro91
reviewed
Oct 2, 2026
| </div> | ||
| <div> | ||
| <label for="size">Choose a size</label> | ||
| <select id="size" name="size"> |
There was a problem hiding this comment.
How can you ensure that the user chooses a size before submitting the form?
Author
There was a problem hiding this comment.
By using the required attribute in the input tag
| this will also help you fill in your PR message later--> | ||
| <div> | ||
| <label for="name">Customer Name:</label> | ||
| <input type="text" id="name" name="name" required pattern=".*\S.*\S.*" title="Name must contain at least two characters."> |
There was a problem hiding this comment.
Well done this also works with special characters like the German ä,ü,ö or Russian ед
Luro91
added
Reviewed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Task ID: CYF-1004
Self checklist
Changelist