-
-
Notifications
You must be signed in to change notification settings - Fork 546
Cape Town | 26-ITP-Sep | Sima Nongawuza | Sprint 1 | CYF-1004 #1529
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
simanongawuza
wants to merge
8
commits into
CodeYourFuture:main
Choose a base branch
from
simanongawuza:feature/form-controls
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
d314ba4
Added the first form to collect customer name
simanongawuza fba7ab7
Added the form to collect Email address
simanongawuza 3177dfc
Added the option to choose a colour
simanongawuza 4a09ac2
Added an option to choose size
simanongawuza a2541f9
Added the sixth size option
simanongawuza 6ece0e9
Addition of regex for the name collection
simanongawuza 35b0581
Added my name on the footer
simanongawuza 73c7b0d
Added a submit button
simanongawuza File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -13,15 +13,41 @@ <h1>Product Pick</h1> | |
| </header> | ||
| <main> | ||
| <form> | ||
| <!-- write your html here--> | ||
| <!-- | ||
| try writing out the requirements first as comments | ||
| this will also help you fill in your PR message later--> | ||
| <div> | ||
| <label for="name">Customer Name:</label> | ||
| <input type="text" id="name" name="name" required pattern=".*\S.*\S.*" title="Name must contain at least two characters."> | ||
| </div> | ||
| <label for="email">Email Address:</label> | ||
| <input for="email" id="email" name="email" required> | ||
| </div> | ||
| <div> | ||
| <label for="Colour">Choose a Colour</label> | ||
| <select id="name" name="colour" required > | ||
| <option value="">Please choose colour:</option> | ||
| <option value="White">White</option> | ||
| <option value="Black">Black</option> | ||
| <option value="Green">Green</option> | ||
| </select> | ||
| </div> | ||
| <div> | ||
| <label for="size">Choose a size</label> | ||
| <select id="size" name="size"> | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. How can you ensure that the user chooses a size before submitting the form?
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. By using the required attribute in the input tag |
||
| <option value="">Please choose a size:</option> | ||
| <option value="XS">XS</option> | ||
| <option value="S">S</option> | ||
| <option value="M">M</option> | ||
| <option value="L">L</option> | ||
| <option value="XL">XL</option> | ||
| <option value="XXL">XXL</option> | ||
| </select> | ||
| </div> | ||
| <div> | ||
| <button type="submit">Submit</button> | ||
| </div> | ||
| </form> | ||
| </main> | ||
| <footer> | ||
| <!-- change to your name--> | ||
| <p>By HOMEWORK SOLUTION</p> | ||
| <p>By SIMA NONGAWUZA</p> | ||
| </footer> | ||
| </body> | ||
| </html> | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well done this also works with special characters like the German ä,ü,ö or Russian ед