Skip to content

fix(ci): record fatal sidecar startup probe stacks - #2462

Merged
seonghobae merged 1 commit into
mainfrom
fix/945-sidecar-native-crash-diagnostics
Sep 27, 2026
Merged

seonghobae merged 1 commit into
mainfrom
fix/945-sidecar-native-crash-diagnostics

Conversation

@seonghobae

Copy link
Copy Markdown
Contributor

Purpose

PR #1026 exact head 03bbd9b4e436723a4ad84688e871b3658367aeb5 failed Noema sidecar provisioning in run 36320408930, job 108641784937 on cwlab-s1-02. The offline HTTP boundary probe terminated with signal 11 (exit 139) before any model review. The current log contains the heredoc source but no crash stack, preventing attribution to interpreter/runtime versus a specific call.

Enable Python stdlib faulthandler only inside that fixed offline probe, before orchestrator imports. Fatal output contains stack locations and no frame locals or request bodies. The existing failing exit and all HTTP/body/tool-description assertions remain intact. This is diagnostic instrumentation, not a claim that the native crash is fixed.

Verification

  • GITHUB_ACTIONS=true: sidecar contract suite, 30 passed.
  • bash -n scripts/ci/contextual_orchestrator_review_sidecar.sh: passed.
  • git diff --check: passed.

After central integration, run a fresh trusted same-head Noema dispatch and inspect any fatal stack. Do not count a missing model verdict as approval and do not bypass #1026.

@coderabbitai

coderabbitai Bot commented Sep 27, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

Next included review available in 57 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: 649a484d-ab9d-4bb8-8156-df98922d3373

📥 Commits

Reviewing files that changed from the base of the PR and between 0a91c1d and 78f4e3e.

📒 Files selected for processing (2)
  • scripts/ci/contextual_orchestrator_review_sidecar.sh
  • tests/test_contextual_orchestrator_review_sidecar_contract.py

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@seonghobae
seonghobae merged commit c9b815b into main Sep 27, 2026
7 of 19 checks passed
@seonghobae
seonghobae deleted the fix/945-sidecar-native-crash-diagnostics branch September 27, 2026 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant