Skip to content

fix(ci): record fatal sidecar startup probe stacks #2462

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
seonghobae merged 1 commit into from
Sep 27, 2026
Merged

fix(ci): record fatal sidecar startup probe stacks #2462

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions scripts/ci/contextual_orchestrator_review_sidecar.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,6 +113,11 @@ log "installing hash-pinned orchestrator dependencies at ${checked_out}"
PYTHONPATH="$ORCHESTRATOR_SOURCE:$ORG_REPO_ROOT" "$sidecar_python" -c \
'from contextual_orchestrator.credentials import get_credential; from contextual_orchestrator.model_discovery import discover_all_models, free_discovered_models; from contextual_orchestrator.orchestrator import ModelClient, TaskOrchestrator, load_agents; from contextual_orchestrator.review_gateway import register_review_credentials; from contextual_orchestrator.server import SecurityConfig, serve'
PYTHONPATH="$ORCHESTRATOR_SOURCE:$ORG_REPO_ROOT" "$sidecar_python" - <<'PY'
import faulthandler

# Fatal startup diagnostics contain stack locations, never frame locals.
faulthandler.enable()

import contextlib
import http.client
import io
Expand Down
3 changes: 3 additions & 0 deletions tests/test_contextual_orchestrator_review_sidecar_contract.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -397,6 +397,9 @@ def test_strix_gateway_uses_provider_neutral_reasoning_effort() -> None:
def test_sidecar_probes_the_pinned_server_body_limit_at_http_boundary() -> None:
"""The exact vendored SHA must enforce the review limit at its HTTP boundary."""
text = _read(SIDECAR)
assert text.index("faulthandler.enable()") < text.index(
"from contextual_orchestrator.server import SecurityConfig, build_server"
)
assert "from contextual_orchestrator.server import SecurityConfig, build_server" in text
assert '"POST",' in text
assert '"/v1/chat/completions",' in text
Expand Down
Loading