feat(reports): leftover-map comparison graphic leftover-map axis leftover-map singular values as leftoverMapComparePlotAxisBadge (v2.83.0) - #867
Conversation
…over-map singular values as leftoverMapComparePlotAxisBadge (v2.83.0)
Caption leftover-map comparison graphic leftover-map axes with persisted leftover-map singular values σ_k through leftoverMapComparePlotAxisBadge (ADR 0326). Comparison graphic copy stays leftover map comparison graphic leftover-map axis {k} σ {value} when share is omitted so it stays distinct from leftover-axis leftover axis {k} σ {value}, from hyphen leftover-map axis {k} σ {value}, and from comparison leftover-axis leftover map comparison leftover axis {k} σ {value}. Rank-0 unused axes still name σ 0.00. Share and singular value omit independently. Do not invent σ_k from leftover-map axis share. Do not invent leftover-map axis share from σ_k. Never invent a leftover score. Never invent a theta.
📝 WalkthroughWalkthrough비교 그래프 축 배지 생성 함수가 추가되었습니다. 함수는 singular 값과 share 값을 독립적으로 포맷하고, 값 조합에 따라 배지 템플릿을 선택합니다. 관련 소스 계약 테스트도 추가되었습니다. Changes비교 그래프 축 배지
Priority: ⬇️ Low Estimated code review effort: 2 (Simple) | ~10 minutes Change: Feature Merge Risk: 🔵 Low · up to The comparison graphic continues to show the existing strip-style captions rather than the new graphic-specific labels. Connect the helper and cover its supported value states before merging. 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches 💡 1📝 Generate docstrings 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
| export function leftoverMapComparePlotAxisBadge( | ||
| axisIndex: number, | ||
| leftoverSingular: number | null | undefined, | ||
| leftoverShare: number | null | undefined, | ||
| ): LeftoverMapCompareAxisBadge | null { | ||
| const singular = formatLeftoverMapPlotAxisSingular(leftoverSingular); | ||
| const percent = formatLeftoverMapPlotAxisShare(leftoverShare); | ||
| if (singular === null && percent === null) { | ||
| return null; | ||
| } | ||
| if (singular === null && percent !== null) { | ||
| return { key: LEFTOVER_MAP_COMPARE_PLOT_AXIS_SHARE, values: { axis: axisIndex, share: percent } }; | ||
| } | ||
| if (singular !== null && percent === null) { | ||
| return { | ||
| key: LEFTOVER_MAP_COMPARE_PLOT_AXIS_SINGULAR, | ||
| values: { axis: axisIndex, value: singular }, | ||
| }; | ||
| } | ||
| return { | ||
| key: LEFTOVER_MAP_COMPARE_PLOT_AXIS_SINGULAR_SHARE, | ||
| values: { axis: axisIndex, value: singular as string, share: percent as string }, | ||
| }; | ||
| } |
There was a problem hiding this comment.
📝 Info: Badge decision table remains equivalent
leftoverMapComparePlotAxisBadge preserves all four prior singular-value and share combinations. Existing localization keys and fallback text therefore remain unchanged.
Was this helpful? React with 👍 or 👎 to provide feedback.
|
Cycle 2026-08-31 12:16 KST. Writes work as seonghobae. Exact head |
|
Cycle 2026-08-31 12:16 KST. Writes work. Exact head Next buyer increment after this stacked σ_k surface: leftover-map graphic leftover-map axis ticks naming persisted σ_k independently of leftover-map axis share (named helper leftoverMapPlotTickAxisBadge matching leftoverMapComparePlotAxisBadge / leftoverMapPlotAxisBadge / leftoverMapCompareAxisBadge / leftoverMapAxisBadge), or leftover-map comparison graphic leftover-map axis ticks naming persisted σ_k independently of leftover-map axis share, or the next already-persisted leftover-map quantity that still has no buyer caption. Do not persist leftover-map inner product, cosine, or length. Synthetic fixtures only. |
|
Queue cycle 2026-08-31T12:17 KST: leftover-map comparison graphic leftover-map axis leftover-map singular values as leftoverMapComparePlotAxisBadge (v2.83.0) stays open for independent review on exact head |
seonghobae
added
enhancement
ChatGPT Codex Connector
Adopt exact reconstructed #866 as the current tree while preserving historical #867 as first parent. Retain the v2.83 product delta as executable RED: comparison-graphic axes must preserve persisted σ when share is missing and keep σ/share states independent, without inference or clamping. Exact #866 is the second parent. No force update or destructive rebase.
Adopt exact reconstructed #867 as the current tree while preserving historical #868 as first parent. Retain the v2.84 product delta as executable RED: report-graphic ticks may name persisted σ independently of share, invalid σ falls back to the ordinary tick, and no share or σ is inferred. Exact #867 is the second parent. No force update or destructive rebase.
Ordinary non-force ancestry adoption. Preserve #867 comparison-graphic axis-badge contract delta while inheriting repaired comparison-distance assertions.
Ordinary non-force ancestry adoption. Preserve the #867 comparison-graphic axis badge contract while inheriting the repaired singular projection chain.
Ordinary non-force ancestry adoption. Preserve the #868 report-graphic tick singular contract while inheriting the repaired singular projection chain.
Preserve the v2.83 comparison-graphic axis badge delta while inheriting the repaired report/comparison axis, responsive-label, and persisted tick-identity contracts. Signed-off-by: Seongho Bae <seonghobae@users.noreply.github.com>
Preserve the v2.84 report-tick persisted-sigma delta while inheriting the repaired comparison badge, responsive-axis, and persisted tick-identity contracts. Signed-off-by: Seongho Bae <seonghobae@users.noreply.github.com>
This branch has not been deployed
1 participant
Current exact authority — 2026-09-21
688643cf317da7ad5b52bd0414dfae1e66da9bbb6b2611ce4d2d7d58acfcbe6b86a5fe640a41ef66This lane preserves its comparison-axis badge product semantics on the current source-repaired #861 ancestry. Exact ancestry from #861 through current #876 has merge-base
69bdb2fc...andbehind_by=0; the parent coordinate-tick identity and responsive axis-caption repairs are inherited rather than replayed here.Fresh exact-head repository/rendered/a11y/security evidence and qualifying independent review remain required. No predecessor receipt transfer, force push, destructive rebase, self-approval, gate weakening, merge, or release is claimed.