Repository navigation
fix(o72): approval-mode copy, no-sandbox notice, once-per-folder untrusted notice - #77
Merged
Merged
Conversation
…e, /mode accept-edits help - full-mode notice keeps 'Shell commands run with your user's full permissions (no sandbox).' (en/zh) - untrusted-folder skipped-settings line shows once per folder; shown again if the list changes - /mode help (onboarding + registry) says shell commands still ask under accept-edits - o72 spec: stderr after a headless block names --full-access and /permissions (accept-edits and manual); --workspace-write -> manual lock; once-per-folder unit + CLI test; /mode help en/zh
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This was referenced Oct 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
O72 (approval-mode copy + UX/safety disclosures), rebased onto current
main675c9d7c(#74 O56 + #75 O55).Changes
-p/--quiet) and how to change it (/mode)./mode manualor--workspace-writefor per-action approval (verified:--workspace-write→ manual).-p/ no TTY blocks a tool, stderr tells the user how to unlock (--full-access,/permissions); the model-facing reason never coaches switching to full mode./modehelp (onboarding + registry): accept-edits says shell commands still ask (en + zh).Commits (on top of
675c9d7c)draft(o72): approval mode line, accept-edits help, headless block copyfix(o72): keep no-sandbox disclosure, once-per-folder untrusted notice, /mode accept-edits helpQA
QA already reviewed local
47d60adb(pre-rebase) and passed (no-sandbox copy locked by spec; stderr names unlock knobs; model reason staysdoesNotMatchcoaching; no assertion loosening). Rebase onto675c9d7conly auto-mergedsrc/cli/config.tswith O55'strustedToolsuser-wins change; tree identical to pre-push tip.Verification (post-rebase)
npm run check(format + eslint + tsc) ✅test/o72-approval-mode-copy.spec.mjs✅cli-permission-defaults,cli-ui-language,workspace-write-copy,first-run,cli-project-instructions,cli-config-merge,o55-user-trustedtools✅Merge order (per PM/Boss)
After O76; before O79 / O57 rebase.