Repository navigation
fix(o70/o67): exit on blackhole proxy; stop background on exit; name refused proxy - #80
Merged
Merged
Conversation
…errors - Stop background exec on CLI shutdown and agent.close; arm 2s -p exit guard (stderr warning; MOSS_DEBUG_EXIT=1 lists handles). - First-chunk timeout copy: no "switching models"; with HTTPS_PROXY do not retry. - Refused proxy: name the proxy, not "Nothing is listening at that base URL". - QA acceptance: test/qa-repro-o67-o70-exit-bundle.spec.mjs (4/4). Base: ed63836. Not pushed.
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
Replace the hardcoded /workspace/ux/acceptance/proxy.py spawn with an in-test net.createServer on 127.0.0.1. That UX path only exists on the agent box, so Ubuntu CI never wrote the port file and qa-repro-o67-o70 failed. Assertions unchanged (BLACKHOLE contact, self-exit, no model coaching, refused-proxy copy).
This was referenced Oct 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Exit reliability bundle for O70 + O67 (blackhole / refused proxy).
QA acceptance (must stay 4/4 PASS)
test/qa-repro-o67-o70-exit-bundle.spec.mjslocks these:switching modelsfrom first-chunk timeout copy —agent-loop-stream-helpers.tsmust not claim the model is switching on first-chunk timeout.stopAllBackgroundProcesseson CLI exit path —cli-main.tsexit path stops goal-exec background processes.HTTPS_PROXY:moss -pself-exits — withMOSS_LLM_FIRST_CHUNK_TIMEOUT_MSset, the process exits on its own (no external kill).Verification
qa-repro-o67-o70-exit-bundle.spec.mjs: 4/4 PASSnpm test: 332 filesBase
ed638367(post fix(o76): always inject core.hooksPath=NUL for untrusted workspaces on win32 #78 / fix(o72): approval-mode copy, no-sandbox notice, once-per-folder untrusted notice #77)