Repository navigation
fix(o87): preserve proxy connect cause; skip rdk-docs warm under HTTPS_PROXY - #84
Merged
Merged
Conversation
…S_PROXY Board lock (board-o67-o70-baseline): same tunnel, only HTTPS_PROXY — MOSS_NO_RDK_DOCS=1 → 11s useful answer; MCP-on → CONNECT present but fails with truncated 网关原文:). H3 = MCP/npx tunnel contention. - Classify UND_ERR_CONNECT_TIMEOUT as network (not model timeout/auth) - Always attach low-level Details for connection failures; drop junk ) - EnvHttpProxyAgent connectTimeout 30s when proxy set (MOSS_CONNECT_TIMEOUT_MS) - Skip eager rdk-docs npx warm under proxy (shouldEagerWarmRdkDocs); tool call still starts it - Fixture: CONNECT-then-blackhole → network + cause, not timeout/auth
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
O87 added the env for proxy connectTimeout but missed the authoritative inventory; cli-config-env.spec failed on Ubuntu CI.
Rewrite MOSS_CONNECT_TIMEOUT_MS EN/ZH notes to prose (代理连接超时 / library default). Skip bare English transport prose under 详细信息 so cli-ui-language stays green; still attach ECONNREFUSED/UND_ERR_* codes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
O87 (板上 P0): CONNECT 有、回答无 — preserve full failure cause, raise proxy
connectTimeout, and skip eager rdk-docs npx warm underHTTPS_PROXYso default MCP-on does not squeeze the main gateway on a narrow reverse tunnel.Board lock (
/workspace/ux/board-o67-o70-baseline.md, tip4b783fc7):HTTPS_PROXY,MOSS_NO_RDK_DOCS=1网关原文:)Acceptance (QA / PM, locked after #83)
网关原文:)HTTPS_PROXY: CONNECT ∧ useful answer even with default MCP on (must not squeeze main gateway)MOSS_NO_RDK_DOCS=1Fix
Cause-complete (priority 1)
UND_ERR_CONNECT_TIMEOUT/ConnectTimeoutErroras network (never model timeout / auth /「换更快的模型」)attach='details'so chat keeps low-level cause (详细信息:…UND_ERR_…))) — never show网关原文:)connection-error.ts: proxy-aware hint for undici connectTimeout (MOSS_CONNECT_TIMEOUT_MS)MCP / tunnel contention (priority 2)
EnvHttpProxyAgentconnectTimeout30s when proxy set (override viaMOSS_CONNECT_TIMEOUT_MS;0= undici default)shouldEagerWarmRdkDocs(env): skip eager rdk-docs npx warm whenHTTPS_PROXY/HTTP_PROXYset; first rdk-docs tool call still starts the serverDoes not touch
src/safety/**orgit-config-env.ts. Independent of #80 exit-hang sign-off.Files
src/provider/errors.tssrc/provider/error-classify.tssrc/provider/connection-error.tssrc/provider/keep-alive-dispatcher.tssrc/cli/rdk-docs-mcp.tssrc/cli-main.tstest/o87-connect-without-answer.spec.mjs(new)test/error-classify-500.spec.mjs(minor assert align)Tests
Coverage:
)→ no网关原文shouldEagerWarmRdkDocsfalse under proxyresolveConnectTimeoutMs30s / override / 0Base
faa5c4e7(main after docs(o66/o85): board proxy + RDK dependency guidance (README + doctor) #83 merge)ae971f6eBoard (UX)
After CI green: re-run matrix — only
HTTPS_PROXY, default MCP vsMOSS_NO_RDK_DOCS=1; lock CONNECT ∧ useful answer + complete cause on failure.