Repository navigation
feat(install): O43/O58 npm one-line install with Node gate - #85
Merged
Merged
Conversation
Recommend `npm install -g @rdk-moss/agent@latest` in README (en+zh). Flip package.json private to false so moss update prints the registry path. Run check-node-version from preinstall and prepare with copyable macOS/Ubuntu/Windows upgrade commands plus the npm i -g success path; fake-version env makes the failure path easy to test without old Node.
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This was referenced Oct 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
O43/O58: make
npm install -g @rdk-moss/agent@latestthe recommended install path (README en+zh), with an immediate Node-too-old failure that prints copyable upgrade commands for macOS / Ubuntu / Windows and the success-pathnpm i -gcommand. No curl native-binary installer in this phase.Changes
package.json:"private": false;preparerunscheck-node-version.cjsbefore build (sonpm install -g --install-links .does not leave a brokenmossshim on old Node)scripts/check-node-version.cjs+bin/node-version-message.cjs: three-platform upgrade commands (brew / nvm / fnm / NodeSource / winget) +npm install -g @rdk-moss/agent@latest; zh locale lead-in;MOSS_TEST_FAKE_NODE_VERSIONfor easy QA/UX failure-path testing--install-linksfixture asserting non-zero exit, upgrade text, and no leftovermossshimsmoss update: withprivate: false, npm-global installs printnpm install -g @rdk-moss/agent@latestAcceptance (PM locked)
npm i -gpath) — exercised viaMOSS_TEST_FAKE_NODE_VERSION=20.19.2 node scripts/check-node-version.cjsandtest/check-node-version-global-install.spec.mjsGate
Local
npm run checkPASSnpm testPASS (339 files)78ea07c326e139ad22f0e63159216e7b4ef2c435(fix(o87): preserve proxy connect cause; skip rdk-docs warm under HTTPS_PROXY #84 merged main tip)