Skip to content

fix(interventions): apply offline dependency defaults individually - #314

Merged
DevSkyLex merged 1 commit into
developfrom
fix/intervention-offline-dependencies
Oct 9, 2026
Merged

DevSkyLex merged 1 commit into
developfrom
fix/intervention-offline-dependencies

Conversation

@DevSkyLex

@DevSkyLex DevSkyLex commented Oct 9, 2026 •

Copy link
Copy Markdown
Owner

The integrated develop analysis reported S7737 because the intervention workspace supplied its offline dependencies through an object literal default parameter. Apply defaults to each destructured dependency instead, so the method factory retains seven parameters and Angular resolves the same services synchronously in the same order.

The public store API and runtime workflow are unchanged. No Sonar rule, issue disposition, threshold or coverage exclusion changes. The source catalog updates only 26 line references after removal of the redundant destructuring statement.

Validation:

  • 108 workspace/catalog Angular tests pass across two files.
  • Full lint, type-aware lint, 75 architecture checks, formatting, authored-source documentation and structural review pass.
  • Strict EN/FR/ES SSR build passes; the existing translation warnings remain.
  • A bounded independent review confirms the dependency order, injection context, per-store resolution and seven-parameter limit.
  • Final integrated develop analysis confirms zero open maintainability issues and 90.4% overall Sonar coverage on 003fdcc. CI: 17/17 jobs succeeded. Dev deployment succeeded with the same source revision and immutable image digest.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 9, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-09T10:32:59.643176Z 156cf6f PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@github-actions github-actions Bot added area:organization Organization or onboarding feature changes area:intervention Intervention workflow or offline mode changes area:i18n Translation catalog changes size:s Small-to-medium PR: under 150 changed lines state:ready Ready for review labels Oct 9, 2026
@DevSkyLex
DevSkyLex merged commit 003fdcc into develop Oct 9, 2026
18 checks passed
@DevSkyLex
DevSkyLex deleted the fix/intervention-offline-dependencies branch October 11, 2026 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:i18n Translation catalog changes area:intervention Intervention workflow or offline mode changes area:organization Organization or onboarding feature changes size:s Small-to-medium PR: under 150 changed lines state:ready Ready for review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant