fix(daemon): enable gateway client transport - #1827
Open
Marc-André Moreau (mamoreau-devolutions) wants to merge 1 commit into
Open
fix(daemon): enable gateway client transport#1827Marc-André Moreau (mamoreau-devolutions) wants to merge 1 commit into
Marc-André Moreau (mamoreau-devolutions) wants to merge 1 commit into
Conversation
Enable the client gateway feature in the daemon dependency so gateway PropertySet values reach the daemon client without downstream feature unification. The daemon now rejects incomplete gateway credentials before starting a session. RDCleanPath and all other transports are unchanged.
Marc-André Moreau (mamoreau-devolutions)
deployed
to
llm-providers
August 29, 2026 00:29 — with
GitHub Actions
Active
Copilot started reviewing on behalf of
Marc-André Moreau (mamoreau-devolutions)
August 29, 2026 00:30
View session
Contributor
There was a problem hiding this comment.
Pull request overview
Enables RD Gateway transport for daemon sessions without relying on downstream feature unification.
Changes:
- Enables
ironrdp-client’sgatewayfeature. - Adds gateway credential validation coverage.
- Updates tests to use the client output-channel abstraction.
Documentation/prose review was not applicable.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
crates/ironrdp-daemon/Cargo.toml |
Enables gateway client transport. |
crates/ironrdp-daemon/src/daemon.rs |
Tests gateway validation and output events. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enable the client gateway feature in the daemon dependency so gateway PropertySet values reach the daemon client without downstream feature unification.
The daemon now rejects incomplete gateway credentials before starting a session. RDCleanPath and all other transports are unchanged.