feat(credssp): use the KdcResolution enum instead of KDC url - #1987
Open
Rostyslav-Romanets wants to merge 1 commit into
Open
Rostyslav-Romanets wants to merge 1 commit into
Rostyslav-Romanets wants to merge 1 commit into
Conversation
This was referenced Sep 24, 2026
Rostyslav-Romanets
marked this pull request as ready for review
September 24, 2026 15:44
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Local path overrides break clean checkouts, and the testsuite imports an incompatible KdcResolution type.
Get a fresh assessment by requesting another Copilot review.
Review effort: Balanced
Findings: 1
Open (3)
What changed in this PR
Updates CredSSP Kerberos configuration for sspi 0.22 and IAKERB-based KDC resolution.
Changes:
- Adds
KdcResolutionand Kerberos configuration constructors. - Migrates client, web, and test code to the new API.
- Updates
sspi,picky, and related dependencies.
| File | Description |
|---|---|
Cargo.toml |
Adds local dependency overrides. |
Cargo.lock |
Updates the resolved dependency graph. |
ffi/Cargo.toml |
Upgrades sspi. |
crates/ironrdp/Cargo.toml |
Upgrades example dependency on sspi. |
crates/ironrdp-web/src/session.rs |
Uses URL-based KDC resolution. |
crates/ironrdp-testsuite-extra/tests/client/config.rs |
Updates the KDC URL assertion. |
crates/ironrdp-mstsgu/Cargo.toml |
Upgrades sspi and picky. |
crates/ironrdp-connector/src/credssp.rs |
Adds KDC strategies and conversion to sspi. |
crates/ironrdp-connector/Cargo.toml |
Upgrades authentication dependencies. |
crates/ironrdp-client/src/config.rs |
Maps configuration properties to KDC resolution. |
crates/ironrdp-acceptor/src/credssp.rs |
Propagates request length errors. |
| # In the meantime, we use this forked version which fixes an undefined behavior in the code expanded by the bridge macro. | ||
| diplomat = { git = "https://github.com/CBenoit/diplomat", rev = "6dc806e80162b6b39509a04a2835744236cd2396" } | ||
|
|
||
| sspi = { path = "../sspi-rs" } |
| ironrdp-error = { path = "../ironrdp-error", version = "0.2" } # public | ||
| ironrdp-pdu = { path = "../ironrdp-pdu", version = "0.9", features = ["std"] } # public | ||
| sspi = { version = "0.21", features = ["scard"] } | ||
| sspi = { version = "0.22", features = ["scard"] } |
|
|
||
| use std::sync::Arc; | ||
|
|
||
| use ironrdp::connector::sspi::KdcResolution; |
github-actions
Bot
added
maintainer-required
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the
KdcResolutionenum, which specifies how Kerberos should resolve the KDC, either by using IAKERB proxy or by connecting directly to an external KDC specified by URL.THis PR is part of integration of the IAKERB extension in
sspi-rsand updates the codebase to use the updated public API ofsspi-rs.Related PRs