feat(picky-krb): add IAKerb proxy message encoding/decoding - #531
Open
Rostyslav-Romanets wants to merge 1 commit into
Open
Rostyslav-Romanets wants to merge 1 commit into
Rostyslav-Romanets wants to merge 1 commit into
Conversation
Rostyslav-Romanets
marked this pull request as draft
September 24, 2026 14:46
Rostyslav-Romanets
marked this pull request as ready for review
September 24, 2026 15:44
Marc-André Moreau (mamoreau-devolutions)
requested a balanced review from Copilot
September 25, 2026 19:50
Copilot started reviewing on behalf of
Marc-André Moreau (mamoreau-devolutions)
September 25, 2026 19:50
View session
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Decoding does not enforce outer framing boundaries or handle valid unknown header extensions.
Get a fresh assessment by requesting another Copilot review.
Review effort: Balanced
Findings: 1
Open (3)
What changed in this PR
Adds IAKERB proxy message support for downstream Kerberos proxy integrations.
Changes:
- Adds IAKERB headers, constants, error codes, and mechanism OID.
- Implements proxy message encoding/decoding.
- Adds DER round-trip tests.
| File | Description |
|---|---|
picky-krb/src/messages.rs |
Defines the IAKERB header and tests. |
picky-krb/src/gss_api.rs |
Implements proxy token encoding and decoding. |
picky-krb/src/constants.rs |
Adds IAKERB token and error constants. |
picky-asn1-x509/src/oids.rs |
Registers the IAKERB mechanism OID. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+230
to
+233
| let max_len = data.len(); | ||
| let mut reader = &mut data; | ||
| let Container { iakerb_oid } = | ||
| Container::deserialize(&mut picky_asn1_der::Deserializer::new_from_reader(&mut reader, max_len))?; |
Comment on lines
+473
to
+475
| // This field is not specified in the RFC but present in real messages. | ||
| #[serde(default)] | ||
| pub flags: Optional<Option<ExplicitContextTag3<BitStringAsn1>>>, |
| } | ||
| } | ||
|
|
||
| /// Opaque data, if sent by the server, MUST be copied by the client verbatim into the next IAKRB_PROXY message. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements encoding and decoding of the
IAKERB_PROXYmessage (IAKrbProxyMessage) according to the IAKERB specification. The implementation is also covered with unit-tests.What is IAKERB
IAKERB extends Kerberos to support scenarios where the client cannot directly access the KDC. Instead, KDC messages are encapsulated in GSS-API tokens and exchanged through an IAKERB proxy. The server forwards these messages to the LocalKDC, allowing the client to obtain the required Kerberos tickets without direct network access to the KDC.
Microsoft recently introduced IAKERB support in Windows Insider builds as part of its effort to reduce NTLM dependency: https://techcommunity.microsoft.com/blog/windows-itpro-blog/reducing-ntlm-dependency-iakerb-and-localkdc-in-windows-insider-preview/4524615.
Related PRs
KdcResolutionenum instead of KDC url IronRDP#1987