Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
PolylineExtensions.Explode()throwsArgumentOutOfRangeException: The radius must be greater than 0.when a vertex has a bulge but the next vertex is at the same location (a zero-length segment).Explode()decides between a line and an arc only fromBulge, so it callsArc.CreateFromBulgewith two equal points, which produces a zero radius.This change treats a bulged segment with equal start and end points as a line, the same way a zero-length straight segment is already exploded. @ghostid suggested the same approach in the issue.
Tasks done in this PR
Related Issues / Pull Requests
GetPoints()(bounding box). This PR coversExplode()only, so the two don't overlap.Notes for reviewer
LwPolylineTests.ExplodeBulgeOverZeroLengthSegmentfails onmasterwith the exception from the issue and passes with the fix.dotnet test src/ACadSharp.Tests -f net9.0: 2489 passed.AddCadObjectStressTestandRemoveCadObjectStressTestfail on my machine with and without this change (timing assertions), so they're unrelated.PolyLine.Explode(IPolyline)(internal static) holds a copy of the same loop but has no callers, so I left it alone.