Skip to content

Explode a bulge over a zero-length segment as a line #1339

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
komal0000 wants to merge 1 commit into
base: master
Choose a base branch
from
+22 −4
Open

Explode a bulge over a zero-length segment as a line #1339

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions src/ACadSharp.Tests/Entities/LwPolylineTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,6 +115,23 @@ public void ExplodeClosedInLines()
}
}

[Fact]
public void ExplodeBulgeOverZeroLengthSegment()
{
LwPolyline lwPolyline = new LwPolyline();
lwPolyline.Vertices.Add(new LwPolyline.Vertex(new XY(0, 0)) { Bulge = 1.0 });
lwPolyline.Vertices.Add(new LwPolyline.Vertex(new XY(0, 0)));
lwPolyline.Vertices.Add(new LwPolyline.Vertex(new XY(10, 0)));

List<Entity> entities = lwPolyline.Explode().ToList();

Assert.Equal(2, entities.Count);
Line l = Assert.IsType<Line>(entities[0]);
Assert.Equal(XYZ.Zero, l.StartPoint);
Assert.Equal(XYZ.Zero, l.EndPoint);
Assert.IsType<Line>(entities[1]);
}

public override void GetBoundingBoxTest()
{
}
Expand Down
9 changes: 5 additions & 4 deletions src/ACadSharp/Extensions/PolylineExtensions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,8 +32,12 @@ public static IEnumerable<Entity> Explode(this IPolyline polyline)
break;
}

XY p1 = curr.Location.Convert<XY>();
XY p2 = next.Location.Convert<XY>();

Entity e = null;
if (curr.Bulge == 0)
//A bulge over a zero-length segment has no arc to create
if (curr.Bulge == 0 || p1.Equals(p2))
{
//Is a line
e = new Line
Expand All @@ -46,9 +50,6 @@ public static IEnumerable<Entity> Explode(this IPolyline polyline)
}
else
{
XY p1 = curr.Location.Convert<XY>();
XY p2 = next.Location.Convert<XY>();

//Is an arc
Arc arc = Arc.CreateFromBulge(p1, p2, curr.Bulge);
arc.Center = new XYZ(arc.Center.X, arc.Center.Y, polyline.Elevation);
Expand Down