Expose visual tab selection override in skin API - #2273
Merged
EllesmereGaming merged 1 commit intoSep 27, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds SetTabSelection(tab, selected) to the public skin API so addons can keep tab highlighting in sync with their own pages.
Passing true or false overrides the visual selection; nil restores native selection. This fixes cases where an addon tab and a Blizzard tab appear selected at the same time, without changing Blizzard’s tab state.
How was it tested?
In-game.
Screenshots
Checklist
HookScript/hooksecurefunconly, neverSetScripton Blizzard framesRelated PR: Adds EllesmereUI skin support to What's Training and uses this API to keep tab highlighting in sync: fusionpit/WhatsTraining#44