Conversation
5 tasks
Author
|
I also created a PR for Ellesmere to support the tab selection API: EllesmereGaming/EllesmereUI#2273 |
Owner
|
Thanks for this, I will take a look at it sooner rather than later. One thing is that the latest build of the game introduced more avenues for taint when modifying the spellbook in any way. I'm still looking into what this means for this addon, but I may need to "fake" the tab in the spellbook to avoid touching anything Blizzard related. |
Author
|
Thanks for taking a look! No pressure at all, especially with the new taint issues. If you end up changing how the tab works, just let me know if there’s anything I should adjust in the PR. Happy to adapt it to whatever approach works best. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds optional EllesmereUI skin support to What's Training, including the spellbook view and standalone window.
The skin follows EllesmereUI’s settings, with matching controls, fonts, and tab styling. The default appearance stays unchanged when the skin is disabled.
This also requires a small EllesmereUI API addition (SetTabSelection) to keep tab highlighting in sync. The addon still works without it, but the styling and tab highlighting won’t look quite right.