Skip to content

add Ellesmere skin support for spellbook and compact frames - #44

Open
takiguru wants to merge 1 commit into
fusionpit:foreverfrom
takiguru:ellesmere-skin
Open

takiguru wants to merge 1 commit into
fusionpit:foreverfrom
takiguru:ellesmere-skin

Conversation

@takiguru

Copy link
Copy Markdown

Adds optional EllesmereUI skin support to What's Training, including the spellbook view and standalone window.
The skin follows EllesmereUI’s settings, with matching controls, fonts, and tab styling. The default appearance stays unchanged when the skin is disabled.
This also requires a small EllesmereUI API addition (SetTabSelection) to keep tab highlighting in sync. The addon still works without it, but the styling and tab highlighting won’t look quite right.

Discord_4Zjuy1wEgb

@takiguru

Copy link
Copy Markdown
Author

I also created a PR for Ellesmere to support the tab selection API: EllesmereGaming/EllesmereUI#2273

@fusionpit

Copy link
Copy Markdown
Owner

Thanks for this, I will take a look at it sooner rather than later. One thing is that the latest build of the game introduced more avenues for taint when modifying the spellbook in any way. I'm still looking into what this means for this addon, but I may need to "fake" the tab in the spellbook to avoid touching anything Blizzard related.

@takiguru

Copy link
Copy Markdown
Author

Thanks for taking a look! No pressure at all, especially with the new taint issues. If you end up changing how the tab works, just let me know if there’s anything I should adjust in the PR. Happy to adapt it to whatever approach works best.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants