Repository navigation
Conversation
…machine's saved settings, and an answer that changes run to run is not measured
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two guards for the same property: a golden should mean the same thing on every machine, every day.
-Aon the VFP command line. Without it, the measuring machine's saved settings (Tools > Options > "Set as Default") leak into every golden:ref_buffering.expectedneedsSET MULTILOCKS ONto reproduce,ref_backward.expectedneedsSET DECIMALS TO 12. With-A, every machine measures from the factory state, and a golden that needs a setting says so in its own first line.Each golden is measured twice. An answer that changes from run to run — a clock, the record of a time — is not a golden, and nothing in a single run says so. With this change,
--checkonprocs.prg(which prints a seconds-since-midnight value on 9.0.0.7423) reportsNOT MEASURED - what it printed changes from run to runinstead of a diff that looks like a product disagreement; a deterministic golden still reportsagrees.Note: the first sweep after this lands will flag the goldens that depended on saved settings — that is the point, and the settings-dependent issue lists the ones found so far. This PR changes the harness only, never a
.expected, so CI is unaffected.Fixes #34 and #35.