Skip to content

Goldens are measured from a factory start, and twice #40

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
hemstreet wants to merge 1 commit into
base: main
Choose a base branch
from
+12 −2
Open

Goldens are measured from a factory start, and twice #40

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 12 additions & 2 deletions scripts/vfp-expected.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -204,7 +204,7 @@ export async function askVfp(source, { timeoutMs = TIMEOUT_MS } = {}) {
stage(run);
writeFileSync(join(dir, 'probe.prg'), WRAPPER);
await new Promise((done) => {
const child = execFile(VFP, [join(dir, 'probe.prg')], { cwd: run }, () => done());
const child = execFile(VFP, ['-A', join(dir, 'probe.prg')], { cwd: run }, () => done());
const timer = setTimeout(() => {
try {
child.kill();
Expand Down Expand Up @@ -387,7 +387,17 @@ async function main() {
const source = readFileSync(path, 'latin1');
const answer = await askVfp(source);
const name = basename(path);
const why = whyNotMeasured(answer);
let why = whyNotMeasured(answer);
if (!why) {
// Asked twice, because an answer that changes from run to run - a clock, the record of a
// time - is not a golden either, and nothing in a single run says so. The second run also
// has to be measurable: a program that asked a person once may not ask the next time.
const again = await askVfp(source);
why = whyNotMeasured(again);
if (!why && answer.text !== again.text) {
why = 'what it printed changes from run to run';
}
}
if (why) {
unmeasured += 1;
manifest.set(name, why);
Expand Down
Loading