Skip to content

Fix validation of reservoir region for wells - #4167

Open
dkachuma wants to merge 3 commits into
developfrom
dk/validate-well-constraint-region
Open

Fix validation of reservoir region for wells#4167
dkachuma wants to merge 3 commits into
developfrom
dk/validate-well-constraint-region

Conversation

@dkachuma

@dkachuma dkachuma commented Oct 20, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

The main issue is that the check at SinglePhaseWell.cpp:198 was reversed while the similar check at CompositionalMultiphaseWell.cpp:418 was correct.

As a result for a single phase simulation I was getting warnings of the form below even though the well is set to use surface conditions.

***** Warning
***** LOCATION: /workrd/users/j0272141/GEOS/SOURCE/geos02/src/coreComponents/physicsSolvers/fluidFlow/wells/SinglePhaseWell.cpp:213
***** Rank 0
***** Message from WELL.CONTROL (thermal_compressible_single_phase_wells_1d.xml, l.38):
referenceReservoirRegion not set: well constraint fluid property calculations will use top segement pressure and temp

This PR fixes this by moving the check into the super class.

@dkachuma dkachuma self-assigned this Oct 20, 2026
@dkachuma dkachuma added type: cleanup / refactor Non-functional change (NFC) flag: ready for review ci: run integrated tests Allows to run the integrated tests in GEOS CI flag: no rebaseline Does not require rebaseline ci: run code coverage enables running of the code coverage CI jobs ci: run device builds Allows to run the device (CUDA/HIP) builds labels Oct 20, 2026
@dkachuma
dkachuma marked this pull request as ready for review October 20, 2026 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rrsettgast rrsettgast Awaiting requested review from rrsettgast rrsettgast is a code owner
@tjb-ltk tjb-ltk Awaiting requested review from tjb-ltk tjb-ltk is a code owner
@OmarDuran OmarDuran Awaiting requested review from OmarDuran OmarDuran is a code owner
@jhuang2601 jhuang2601 Awaiting requested review from jhuang2601 jhuang2601 is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

@dkachuma dkachuma

Labels

ci: run code coverage enables running of the code coverage CI jobs ci: run device builds Allows to run the device (CUDA/HIP) builds ci: run integrated tests Allows to run the integrated tests in GEOS CI flag: no rebaseline Does not require rebaseline flag: ready for review type: cleanup / refactor Non-functional change (NFC)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@dkachuma