Skip to content

Fix validation of reservoir region for wells #4167

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dkachuma wants to merge 3 commits into
base: develop
Choose a base branch
from
Open

Fix validation of reservoir region for wells #4167

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
432ccdd
Move method to base class
dkachuma Oct 20, 2026
3db683e
Fix typo in message
dkachuma Oct 20, 2026
99172a1
Merge branch 'develop' into dk/validate-well-constraint-region
dkachuma Oct 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 2 additions & 17 deletions src/coreComponents/physicsSolvers/fluidFlow/wells/CompositionalMultiphaseWell.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -413,26 +413,11 @@ void CompositionalMultiphaseWell::validateFluidModel(
}
}


void CompositionalMultiphaseWell::validateWellConstraints( real64 const & time_n,
real64 const & GEOS_UNUSED_PARAM( dt ),
real64 const & dt,
WellElementSubRegion const & subRegion )
{
GEOS_UNUSED_VAR( time_n );

if( !useSurfaceConditions() )
{
bool const useSegmentValues = referenceReservoirRegion().empty();

static bool firstNoRefRegionMsg = true;
if( useSegmentValues && firstNoRefRegionMsg )
{
GEOS_WARNING( WellControls::viewKeyStruct::referenceReservoirRegionString() <<
" not set: well constraint fluid property calculations will use top segement pressure and temp ",
getDataContext() );
firstNoRefRegionMsg = false;
}
}
WellControls::validateWellConstraints( time_n, dt, subRegion );

string const & fluidName = subRegion.getReference< string >( viewKeyStruct::fluidNamesString());
MultiFluidBase const & fluid = subRegion.getConstitutiveModel< MultiFluidBase >( fluidName );
Expand Down
6 changes: 3 additions & 3 deletions src/coreComponents/physicsSolvers/fluidFlow/wells/CompositionalMultiphaseWell.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -400,9 +400,9 @@ class CompositionalMultiphaseWell : public WellControls
* @param subRegion the well subRegion
* @param elemManager the element manager
*/
virtual void validateWellConstraints( real64 const & time_n,
real64 const & dt,
WellElementSubRegion const & subRegion ) override;
void validateWellConstraints( real64 const & time_n,
real64 const & dt,
WellElementSubRegion const & subRegion ) override;

/**
* @brief Create well separator
Expand Down
22 changes: 0 additions & 22 deletions src/coreComponents/physicsSolvers/fluidFlow/wells/SinglePhaseWell.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -188,28 +188,6 @@ string SinglePhaseWell::resElementDofName() const
return SinglePhaseBase::viewKeyStruct::elemDofFieldString();
}

void SinglePhaseWell::validateWellConstraints( real64 const & time_n,
real64 const & GEOS_UNUSED_PARAM( dt ),
WellElementSubRegion const & subRegion )
{
GEOS_UNUSED_VAR( time_n );
GEOS_UNUSED_VAR( subRegion );

if( useSurfaceConditions() )
{
bool const useSegmentValues = referenceReservoirRegion().empty();

static bool firstNoRefRegionMsg = true;
if( useSegmentValues && firstNoRefRegionMsg )
{
GEOS_WARNING( WellControls::viewKeyStruct::referenceReservoirRegionString() <<
" not set: well constraint fluid property calculations will use top segement pressure and temp ",
getDataContext() );
firstNoRefRegionMsg = false;
}
}
}

void SinglePhaseWell::initializeWellPostInitialConditionsPreSubGroups( WellElementSubRegion & subRegion )
{

Expand Down
13 changes: 0 additions & 13 deletions src/coreComponents/physicsSolvers/fluidFlow/wells/SinglePhaseWell.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -335,19 +335,6 @@ class SinglePhaseWell : public WellControls

ReferenceConditions getReferenceConditions( WellElementSubRegion const & subRegion );

/**
* @brief Make sure that the well constraints are compatible
* @param time_n the time at the beginning of the time step
* @param dt the time step dt
* @param subRegion the well subRegion
*/
virtual void validateWellConstraints( real64 const & time_n,
real64 const & dt,
WellElementSubRegion const & subRegion
) override;



/**
* @brief Create well separator
*/
Expand Down
19 changes: 19 additions & 0 deletions src/coreComponents/physicsSolvers/fluidFlow/wells/WellControls.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -248,6 +248,25 @@ void WellControls::registerWellDataOnMesh( WellElementSubRegion & subRegion )
}
}

void WellControls::validateWellConstraints( real64 const & GEOS_UNUSED_PARAM( time_n ),
real64 const & GEOS_UNUSED_PARAM( dt ),
WellElementSubRegion const & GEOS_UNUSED_PARAM( subRegion ))
{
if( !useSurfaceConditions() )
{
bool const useSegmentValues = referenceReservoirRegion().empty();

static bool firstNoRefRegionMsg = true;
if( useSegmentValues && firstNoRefRegionMsg )
{
GEOS_WARNING( WellControls::viewKeyStruct::referenceReservoirRegionString() <<
" not set: well constraint fluid property calculations will use the top segment pressure and temperature",
getDataContext() );
firstNoRefRegionMsg = false;
}
}
}

void WellControls::updateNumDofPerElement()
{
localIndex const numFlowComponents = numFluidComponents();
Expand Down
8 changes: 7 additions & 1 deletion src/coreComponents/physicsSolvers/fluidFlow/wells/WellControls.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -148,9 +148,15 @@ class WellControls : public dataRepository::Group
*/
/**@{*/

/**
* @brief Make sure that the well constraints are compatible
* @param time_n the time at the beginning of the time step
* @param dt the time step dt
* @param subRegion the well subRegion
*/
virtual void validateWellConstraints( real64 const & time_n,
real64 const & dt,
WellElementSubRegion const & subRegion ) = 0;
WellElementSubRegion const & subRegion );

virtual bool isCompositional() const = 0;
/**
Expand Down