feat(*): updating to igniteui-webcomponents 7.3.0 - #380
Open
kdinev wants to merge 18 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The updated dependency set introduces a Node.js version constraint (via igniteui-webcomponents) that should be declared in package.json to avoid contributor install/build failures.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
Updates the repo’s Node/webpack toolchain and bumps igniteui-webcomponents to 7.3.0 for the TypeScript interop bundle that ships as static web assets in the Ignite UI Blazor library.
Changes:
- Bump
igniteui-webcomponentsfrom~7.2.4to~7.3.0(andlit-htmlpatch). - Refresh several webpack-related devDependencies (e.g.,
webpack,webpack-cli, loaders/plugins) and regeneratepackage-lock.jsonaccordingly.
File summaries
| File | Description |
|---|---|
| package.json | Updates igniteui-webcomponents and multiple build-time devDependencies used for bundling JS interop assets. |
| package-lock.json | Regenerated lockfile reflecting the updated dependency graph for the new webcomponents/tooling versions. |
Review details
- Files reviewed: 1/2 changed files
- Comments generated: 1
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Member
|
either should include the matching features from 7.3.0 (assuming some new components & features) or not really a feat and more of a chore; Preferably the first option ofc. |
![github-code-quality[bot]](https://avatars.githubusercontent.com/u/9919?s=60&v=4){kind=small}
| get { return this._margin; } | ||
| set | ||
| { | ||
| if (this._margin != value || !IsPropDirty("Margin")) |
…tion or class' Co-authored-by: Copilot Autofix powered by AI <223894421+github-code-quality[bot]@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <223894421+github-code-quality[bot]@users.noreply.github.com>
Copilot stopped work on behalf of
kdinev due to an error
September 2, 2026 11:05
…tion or class' Co-authored-by: Copilot Autofix powered by AI <223894421+github-code-quality[bot]@users.noreply.github.com>
Reconcile the 7.3.0 component work with master's standalone-skills rewrite (#277) and trim-compatibility work (#359). Skills: master rewrote every SKILL.md and reference file into a condensed, MCP-optional form. Kept that rewrite wholesale and re-applied this branch's new-component documentation in the new style — Color Picker in form-controls.md, QR Code in data-display.md, Virtual Scroll in layout.md, the Chip `Outlined` variant, and the three matching rows in the generate-from-image-design component mapping. Master's condensed Splitter entry gained the `StartCollapsed`/`EndCollapsed` and `LayoutChanged` members this branch documented. Routing tables and the skill description list the new components. All documented members verified against the wrapper sources. Trim compatibility: master's refactor gave every `*Module.cs` the self-referencing `[IgbModule<T>]` attribute and `IIgbModule` interface so the trimmer preserves the reflective `Register` lookup. The three modules added on this branch (`ColorPickerModule`, `QrCodeModule`, `VirtualScrollModule`) predate that and were missed by the textual merge, which would have silently trimmed away their client-resource registration in a trimmed WASM publish — and slipped past `EveryLibraryModule_CarriesSelfReferencingIgbModuleAttribute`, since it only inspects types already implementing `IIgbModule`. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Copilot stopped work on behalf of
kdinev due to an error
September 2, 2026 13:12
Co-authored-by: Copilot Autofix powered by AI <223894421+github-code-quality[bot]@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <223894421+github-code-quality[bot]@users.noreply.github.com>
kdinev
requested review from
damyanpetev
and
a balanced review from Copilot
September 10, 2026 07:04
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The icon options overloads dispatch an incompatible argument shape, and the PR also introduces unresolved source-breaking API changes.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Review details
- Files reviewed: 71/74 changed files
- Comments generated: 9
- Review effort level: Balanced
| /// <param name="name">The unique name for the icon.</param> | ||
| /// <param name="url">The URL to fetch the SVG icon from.</param> | ||
| /// <param name="options">Options controlling the collection and SVG meta stripping.</param> | ||
| public async Task RegisterIconAsync(String name, String url, IgbRegisterIconOptions options) |
| /// <param name="name">The unique name for the icon.</param> | ||
| /// <param name="iconText">The SVG markup as a string.</param> | ||
| /// <param name="options">Options controlling the collection and SVG meta stripping.</param> | ||
| public async Task RegisterIconFromTextAsync(String name, String iconText, IgbRegisterIconOptions options) |
Comment on lines
+200
to
+202
| // Another overload of a method with predefined args. Its arguments cannot be | ||
| // modeled generically (and the predefined set targets the primary overload), | ||
| // so leave it to the unit interop contract. |
Contributor
There was a problem hiding this comment.
Implemented in ec6a1cb: added interop method-contract specs in IconTests for both options overload pairs (RegisterIcon* and RegisterIconFromText*) so the options marshaling path is explicitly exercised.
Comment on lines
+193
to
+194
| /// When <see cref="ErrorLevel"/> is not explicitly set, the smallest error correction level that can | ||
| /// accommodate the requested logo size is chosen automatically. |
Co-authored-by: Copilot Autofix powered by AI <223894421+github-code-quality[bot]@users.noreply.github.com> Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: kdinev <1472513+kdinev@users.noreply.github.com>
Co-authored-by: kdinev <1472513+kdinev@users.noreply.github.com>
damyanpetev
added this pull request to stack #412
September 11, 2026 10:48
damyanpetev
removed this pull request from stack #412
September 11, 2026 11:36
Co-authored-by: damyanpetev <3198469+damyanpetev@users.noreply.github.com>
kdinev
commented
Sep 11, 2026
Co-authored-by: Copilot Autofix powered by AI <223894421+github-code-quality[bot]@users.noreply.github.com> Co-authored-by: Konstantin Dinev <kdinev@infragistics.com>
|
|
||
| private static bool AreDoublesEqual(double left, double right) | ||
| { | ||
| if (left == right) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Motivation / Context
Type of Change (check all that apply):
Component(s) / Area(s) Affected:
How Has This Been Tested?
Test Configuration:
Screenshots / Recordings
Checklist:
README.MDCHANGELOG.MDupdates for newly added functionalityCloses #