Arabic: complete missing translations and fix outdated NewPipe→PipePipe references#79
Arabic: complete missing translations and fix outdated NewPipe→PipePipe references#79AhmedRX20 wants to merge 2 commits into
Conversation
|
Thanks. One issue: |
My bad 🤦 |
|
Hi i did a review to this pull request and 1- keys that doesn't exists in the latest release v5.2.4 2- missing keys arrays New keys added in this merged PR #59 Translate to 3- Wrong translation in Correction
Correction
4- Better alternative translation suggestions Replace to be Replace تعليقات الرصاصة to -> التعليقات العائمة This is because the Literal translation to (bullet comments) might be a bit confusing to the user in what this feature do, so it is better to choose an alternative translation to it that reflects what does this feature might do. Also these translations below needs a small changes to make more sense and to have a better meaning Change To There is a lot more need to be cover but i don't want to make this comment more longer i highly recommend you to re-check your translation since there is some minor changes need to done or if you want i can make a commit to fix these to compare it with your translation and to see what need to be fixed 5- other changes Overall it is a very soild translation greet job. |
|
Hey, thanks a ton for going through all this in detail, really appreciate the effort 🙏 You caught way more than I expected honestly, especially the outdated/missing keys and the bullet comments naming — that's a fair point, "تعليقات الرصاصة" is pretty literal and confusing. I'm gonna close this PR and open a fresh one based on the latest v5.2.4 base file, with all your feedback baked in from the start instead of stacking fixes on top of fixes here. Will tag you on the new one so you can take a look if you want. Thanks again! |
This PR completes the Arabic (ar) translation, which was incomplete after being inherited from NewPipe.
strings.xmlbut were missing entirely fromvalues-ar/strings.xml(new PipePipe features: SponsorBlock, SABR, ExoPlayer settings, filters, proxy, etc.)_newsuffix) entries that still referenced "NewPipe" instead of "PipePipe"\n,%s,%d,%1$dplaceholders preserved as-is