Repository navigation
fix(vendor): make the public-API sweep cover pcapkit.vendor (#1772) - #1779
Conversation
|
Verdict: GOOD TO GO at |
|
Conflicts with #1789 in |
tests/project/test_public_api.py skipped pcapkit.vendor through EXCLUDED_ROOTS for want of requests and bs4, which the test extra has carried since #507. Dropping it failed the package converse check twice: - pcapkit.vendor.ipx leaked `path`, its sys.path temporary: now `_path`. - pcapkit.vendor's Vendor, ModuleNotFoundError, stacklevel, VendorWarning and warn go in DELIBERATE_NON_EXPORTS, not __all__, which pcapkit.vendor.__main__ runs as its default crawler list (now commented). EXCLUDED_ROOTS is empty and the walk pins pcapkit.vendor and its ipx package. The docstring drops the stale exclusion and "one gap remains" (#531) paragraphs; test_crawler_reachability_unit's no longer calls vendor excluded. tests/project: 930 passed, 1 skipped. Closes #1772
|
resolve conflicts |
|
On it: the rebase onto |
|
Verdict: GOOD TO GO at |
7043ac5 to
b5f5fb1
Compare
…1803) Entries: - add #1791 (breaking: pack() leaves its instance unchanged), #1778 (Protocol in protocol.__all__), #1781 (PortEnumField miss with a nameless proto), #1779 (vendor.ipx _path), #1780 (examples READMEs to Markdown, build leftovers) and #1790 (36 ambiguous cross-references) - fold #1776 into the RPL 0x23 entry and #1381 into the dump-schema one Accuracy: - the benchmark and legacy_smoke READMEs are README.md since #1780 - EngineBase stays out of __all__, as #1016 settled - the #575 peek calls get() only once the value resolves - the #647 and #764 entries point at #775/#860, under which nothing mints - the #861 entry names #869 and #874 for the EnumRegistry move Figures: - preamble: 685 citations, #340 to #1791 - process.rst pin: 298 entries; CHANGELOG.md regenerated Refs #1103
Please follow the guide below
You will be asked some questions, please read them carefully and answer honestly
Put an
xinto all the boxes [ ] relevant to your pull request (like that [x])Use Preview tab to see how your pull request will actually look like
Searched for similar pull requests
Followed the coding style (
make pylint,make mypy,make isort)make testpasses, and a test case covers the change. Narrow runs only, listed below.Added a changelog entry under
docs/source/changelog/and regeneratedCHANGELOG.md, if the change is user-visible: N/A — centralised in docs(changelog): shared 1.5.0 changelog — long-lived, merges last (#610, #616, #617, #618, #620) #657What is the purpose of your pull request?
Tick the commit type your subject line carries.
fix— corrects a defectfeat— adds a featureperf— changes performance, not behaviourrefactor— changes neither behaviour nor performancetest— tests onlydocs— documentation onlyci— workflows or build toolingrelease— bumps the version or rolls up a distributionchore— anything elseSummary
tests/project/test_public_api.pyskippedpcapkit.vendorviaEXCLUDED_ROOTS, for want ofrequestsandbs4, but the test extra has carried both since #507. Dropping the exclusion failed the package converse check twice. This PR fixes both failures:pcapkit.vendor.ipxleakedpath, itssys.pathtemporary. It is now_path.pcapkit.vendor'sVendor,ModuleNotFoundError,stacklevel,VendorWarningandwarngo inDELIBERATE_NON_EXPORTS, not__all__.pcapkit.vendor.__main__uses that__all__as its default crawler list, which is now commented.EXCLUDED_ROOTSis empty, and the walk pinspcapkit.vendorandpcapkit.vendor.ipx. Stale prose about the exclusion is dropped in both test files. Rebased ontomainpast docs(tests): correct stale claims in test docstrings and comments (#1103) #1764's edits to the same docstrings.tests/project: 930 passed, 1 skipped.Closes #1772