Skip to content

docs(tests): second pass over tests outside tests/protocols (#1103) - #1789

Merged
JarryShaw merged 1 commit into
mainfrom
docs/1103-tests-rest
Oct 15, 2026
Merged

JarryShaw merged 1 commit into
mainfrom
docs/1103-tests-rest

Conversation

@JarryShaw

@JarryShaw JarryShaw commented Oct 15, 2026 •

Copy link
Copy Markdown
Owner

Please follow the guide below

What is the purpose of your pull request?

Tick the commit type your subject line carries.

  • fix — corrects a defect
  • feat — adds a feature
  • perf — changes performance, not behaviour
  • refactor — changes neither behaviour nor performance
  • test — tests only
  • docs — documentation only
  • ci — workflows or build tooling
  • release — bumps the version or rolls up a distribution
  • chore — anything else

Summary

#1103 round 2: the files phase 1 left unread, plus the phase-1 reviewers' follow-ups.

Prose only: ASTs match the base once docstrings are blanked.

Refs #1103

@JarryShaw JarryShaw added the docs Pull requests that change documentation only (docs: subject prefix) label Oct 15, 2026
@JarryShaw

Copy link
Copy Markdown
Owner Author

Verdict: GOOD TO GO at 433c825f4. Sonnet review and re-check (author: Opus). The first review blocked on the #922 base commit in test_sentinels_housing_unit.py:23. The docstring now says "a main commit from before #922", checked against the PR's base. Stacked on #1788. The AST guard is identical against the base, tests/project passes, and every added directive says 1.5.0.

@JarryShaw JarryShaw added the review: good-to-go Cross-review at the current head says ready; CI state is separate label Oct 15, 2026
@JarryShaw

Copy link
Copy Markdown
Owner Author

Conflicts with #1779 in tests/project/test_public_api.py and tests/vendor/test_crawler_reachability_unit.py; whichever merges second, I rebase.

Prose only: ASTs match the base once docstrings are blanked.

- CI reach: engine-tests no longer collects tests/vendor or
  tests/project (#849); the test extra carries requests and bs4
  (#507); bs4[html5lib] ships in vendor and dev, not all;
  experimental.yml runs pytest too; five workflows install .[all].
- Public API: dropping 'vendor' from EXCLUDED_ROOTS fails for
  pcapkit.vendor and pcapkit.vendor.ipx, tracked in #1772.
- Retired behaviour stated as current: the tracebacklimit side effect
  (#983), minting by Method, AppType and OptionType (#860, #874),
  TransportProtocol as an IntFlag (#808), #734 as open.
- Counts dropped or anchored: __proto__ entries, cyclic-import
  findings, 116 of 117 (#531), the #1748 mutation rows, module,
  workflow and call-site totals.
- References: Method.get's callers, renamed test ids, RFC 959
  section 5.3, a gate cited by line number, "this PR" as #874,
  "this branch" as a main commit from before #922.

Refs #1103
@JarryShaw
JarryShaw force-pushed the docs/1103-tests-rest branch from 433c825 to dbd3282 Compare October 15, 2026 18:18
@JarryShaw
JarryShaw changed the base branch from docs/1103-tests-protocols to main October 15, 2026 18:18
@JarryShaw

Copy link
Copy Markdown
Owner Author

Verdict: GOOD TO GO at dbd32829a. This is 433c825f4 rebased from #1788's branch onto main, with an identical range-diff and patch-id. After the fix round the two PRs share no files, so this one is no longer stacked; it now targets main and gets CI. The earlier verdict carries over.

@JarryShaw JarryShaw closed this Oct 15, 2026
@JarryShaw JarryShaw reopened this Oct 15, 2026
@JarryShaw
JarryShaw merged commit e6e7bdf into main Oct 15, 2026
12 checks passed
@JarryShaw
JarryShaw deleted the docs/1103-tests-rest branch October 15, 2026 18:52
@JarryShaw JarryShaw removed the review: good-to-go Cross-review at the current head says ready; CI state is separate label Oct 15, 2026
@JarryShaw JarryShaw moved this to Done in PyPCAPKit Oct 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs Pull requests that change documentation only (docs: subject prefix)

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

1 participant