Repository navigation
docs(tests): second pass over tests outside tests/protocols (#1103) - #1789
Conversation
|
Verdict: GOOD TO GO at |
|
Conflicts with #1779 in |
Prose only: ASTs match the base once docstrings are blanked. - CI reach: engine-tests no longer collects tests/vendor or tests/project (#849); the test extra carries requests and bs4 (#507); bs4[html5lib] ships in vendor and dev, not all; experimental.yml runs pytest too; five workflows install .[all]. - Public API: dropping 'vendor' from EXCLUDED_ROOTS fails for pcapkit.vendor and pcapkit.vendor.ipx, tracked in #1772. - Retired behaviour stated as current: the tracebacklimit side effect (#983), minting by Method, AppType and OptionType (#860, #874), TransportProtocol as an IntFlag (#808), #734 as open. - Counts dropped or anchored: __proto__ entries, cyclic-import findings, 116 of 117 (#531), the #1748 mutation rows, module, workflow and call-site totals. - References: Method.get's callers, renamed test ids, RFC 959 section 5.3, a gate cited by line number, "this PR" as #874, "this branch" as a main commit from before #922. Refs #1103
433c825 to
dbd3282
Compare
|
Verdict: GOOD TO GO at |
Please follow the guide below
You will be asked some questions, please read them carefully and answer honestly
Put an
xinto all the boxes [ ] relevant to your pull request (like that [x])Use Preview tab to see how your pull request will actually look like
Searched for similar pull requests
Followed the coding style (
make pylint,make mypy,make isort)make testpasses, and a test case covers the change. Narrow runs only, listed below.Added a changelog entry under
docs/source/changelog/and regeneratedCHANGELOG.md, if the change is user-visible: N/A — centralised in docs(changelog): shared 1.5.0 changelog — long-lived, merges last (#610, #616, #617, #618, #620) #657What is the purpose of your pull request?
Tick the commit type your subject line carries.
fix— corrects a defectfeat— adds a featureperf— changes performance, not behaviourrefactor— changes neither behaviour nor performancetest— tests onlydocs— documentation onlyci— workflows or build toolingrelease— bumps the version or rolls up a distributionchore— anything elseSummary
#1103 round 2: the files phase 1 left unread, plus the phase-1 reviewers' follow-ups.
Prose only: ASTs match the base once docstrings are blanked.
tests/project (ci: rebuild engine-tests as a Python × engine matrix with three cell outcomes #849); the test extra carries requests and bs4
(IPX vendor crawler is doubly broken: Wikipedia 403s the default User-Agent, and the socket-number table is gone #507); bs4[html5lib] ships in vendor and dev, not all;
experimental.yml runs pytest too; five workflows install .[all].
pcapkit.vendor and pcapkit.vendor.ipx, tracked in fix(vendor): __all__ gaps keep pcapkit.vendor out of the public-API sweep #1772.
(fix(utilities): stop truncating every traceback for a loud BaseError #983), minting by Method, AppType and OptionType (const: bring the 16 bespoke registries onto EnumRegistry, after fixing the base's str-key dispatch #860, fix(const,vendor): bring the AppType family onto EnumRegistry, stop it minting (#860) #874),
TransportProtocol as an IntFlag (reg: drop TransportProtocol's IntFlag base once nothing builds a composite #808), AppType.get(name) never matches an existing member and silently mints a port=-1 member instead #734 as open.
findings, 116 of 117 (fix(vendor): make the handover_initiate_status crawler reachable (release blocker for
make vendor) #531), the ci(release): a push that releases nothing leaves 10 red conda checks on main while 1.5.0b12 is unfinished (#1634) #1748 mutation rows, module,workflow and call-site totals.
section 5.3, a gate cited by line number, "this PR" as fix(const,vendor): bring the AppType family onto EnumRegistry, stop it minting (#860) #874,
"this branch" as a main commit from before refactor(corekit): house all four sentinels in one shared module (#911) #922.
Refs #1103