Repository navigation
docs(tests): second pass over tests/protocols (#1103) - #1788
Merged
Merged
Conversation
Correct tests/protocols prose that no longer matches the code. Prose only: the AST guard finds all seven files identical. - test_layer_placement_unit: Link sets ten names of its own, not seven, and OSPF loses four of them, `_shipped_proto` included. - test_protocol_code_registration_unit: Engine's registry keyword is `engine=`, renamed from `name=` by #557. - test_http_unit: Command.get's case rule is RFC 959 section 5.3, not 4.1; TCP ports 80 and 8080 bind the version dispatcher, not httpv1.HTTP, so the "straight to this class" claim is dropped. - test_hip_unit: all three two_octet_prefix_list_len call sites take two-octet items, so none is a one-octet contrast. - test_ipv4_unit: the ProtocolBase descendant count is stated as a lower bound, and a test_schema_unit.py line is re-measured. - test_dispatch_reachability_unit: drop the stale count of 38 `__proto__` entries; the registry test pins the number. - test_hip_locator_set_length_unit: rewrap an over-long line. Refs #1103
4 of 13 tasks
Owner
Author
|
Verdict: GOOD TO GO at |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please follow the guide below
You will be asked some questions, please read them carefully and answer honestly
Put an
xinto all the boxes [ ] relevant to your pull request (like that [x])Use Preview tab to see how your pull request will actually look like
Searched for similar pull requests
Followed the coding style (
make pylint,make mypy,make isort)make testpasses, and a test case covers the change. Narrow runs only, listed below.Added a changelog entry under
docs/source/changelog/and regeneratedCHANGELOG.md, if the change is user-visible: N/A — centralised in docs(changelog): shared 1.5.0 changelog — long-lived, merges last (#610, #616, #617, #618, #620) #657What is the purpose of your pull request?
Tick the commit type your subject line carries.
fix— corrects a defectfeat— adds a featureperf— changes performance, not behaviourrefactor— changes neither behaviour nor performancetest— tests onlydocs— documentation onlyci— workflows or build toolingrelease— bumps the version or rolls up a distributionchore— anything elseSummary
#1103 round 2: the files phase 1 left unread, plus the phase-1 reviewers' follow-ups.
Correct tests/protocols prose that no longer matches the code. Prose
only: the AST guard finds all seven files identical.
seven, and OSPF loses four of them,
_shipped_protoincluded.is
engine=, renamed fromname=by fix(foundation): rename Engine's registry keyword toengine, which works on Python 3.10 (#514) #557.not 4.1; TCP ports 80 and 8080 bind the version dispatcher, not
httpv1.HTTP, so the "straight to this class" claim is dropped.
take two-octet items, so none is a one-octet contrast.
lower bound, and a test_schema_unit.py line is re-measured.
__proto__entries; the registry test pins the number.Refs #1103