Skip to content

docs(tests): second pass over tests/protocols (#1103) - #1788

Merged
JarryShaw merged 1 commit into
mainfrom
docs/1103-tests-protocols
Oct 15, 2026
Merged

JarryShaw merged 1 commit into
mainfrom
docs/1103-tests-protocols

Conversation

@JarryShaw

Copy link
Copy Markdown
Owner

Please follow the guide below

What is the purpose of your pull request?

Tick the commit type your subject line carries.

  • fix — corrects a defect
  • feat — adds a feature
  • perf — changes performance, not behaviour
  • refactor — changes neither behaviour nor performance
  • test — tests only
  • docs — documentation only
  • ci — workflows or build tooling
  • release — bumps the version or rolls up a distribution
  • chore — anything else

Summary

#1103 round 2: the files phase 1 left unread, plus the phase-1 reviewers' follow-ups.

Correct tests/protocols prose that no longer matches the code. Prose
only: the AST guard finds all seven files identical.

  • test_layer_placement_unit: Link sets ten names of its own, not
    seven, and OSPF loses four of them, _shipped_proto included.
  • test_protocol_code_registration_unit: Engine's registry keyword
    is engine=, renamed from name= by fix(foundation): rename Engine's registry keyword to engine, which works on Python 3.10 (#514) #557.
  • test_http_unit: Command.get's case rule is RFC 959 section 5.3,
    not 4.1; TCP ports 80 and 8080 bind the version dispatcher, not
    httpv1.HTTP, so the "straight to this class" claim is dropped.
  • test_hip_unit: all three two_octet_prefix_list_len call sites
    take two-octet items, so none is a one-octet contrast.
  • test_ipv4_unit: the ProtocolBase descendant count is stated as a
    lower bound, and a test_schema_unit.py line is re-measured.
  • test_dispatch_reachability_unit: drop the stale count of 38
    __proto__ entries; the registry test pins the number.
  • test_hip_locator_set_length_unit: rewrap an over-long line.

Refs #1103

Correct tests/protocols prose that no longer matches the code. Prose
only: the AST guard finds all seven files identical.

- test_layer_placement_unit: Link sets ten names of its own, not
  seven, and OSPF loses four of them, `_shipped_proto` included.
- test_protocol_code_registration_unit: Engine's registry keyword
  is `engine=`, renamed from `name=` by #557.
- test_http_unit: Command.get's case rule is RFC 959 section 5.3,
  not 4.1; TCP ports 80 and 8080 bind the version dispatcher, not
  httpv1.HTTP, so the "straight to this class" claim is dropped.
- test_hip_unit: all three two_octet_prefix_list_len call sites
  take two-octet items, so none is a one-octet contrast.
- test_ipv4_unit: the ProtocolBase descendant count is stated as a
  lower bound, and a test_schema_unit.py line is re-measured.
- test_dispatch_reachability_unit: drop the stale count of 38
  `__proto__` entries; the registry test pins the number.
- test_hip_locator_set_length_unit: rewrap an over-long line.

Refs #1103
@JarryShaw JarryShaw added the docs Pull requests that change documentation only (docs: subject prefix) label Oct 15, 2026
@JarryShaw

Copy link
Copy Markdown
Owner Author

Verdict: GOOD TO GO at 89b56354c. Sonnet review and re-check (author: Opus). The first review passed. A fix round corrected the one-octet claim at test_hip_unit.py:2001 against schema/internet/hip.py. The AST guard is identical against the base, tests/project passes, and every added directive says 1.5.0.

@JarryShaw JarryShaw added the review: good-to-go Cross-review at the current head says ready; CI state is separate label Oct 15, 2026
@JarryShaw
JarryShaw merged commit f41ca6f into main Oct 15, 2026
13 checks passed
@JarryShaw
JarryShaw deleted the docs/1103-tests-protocols branch October 15, 2026 18:52
@JarryShaw JarryShaw removed the review: good-to-go Cross-review at the current head says ready; CI state is separate label Oct 15, 2026
@JarryShaw JarryShaw moved this to Done in PyPCAPKit Oct 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs Pull requests that change documentation only (docs: subject prefix)

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

1 participant