Repository navigation
ci(conda): report a package pinned differently under one marker (#1852) - #1865
Merged
Merged
Conversation
- util/conda_vendor.py: parse() kept only the last line per package and marker, so a conflicting duplicate pin passed --check while pip download -r rejected the file. It now raises Conflicting naming each such pair, and compare() reports each as a conflict: problem, so --check exits 1. - An identical duplicate line is accepted, since pip resolves it. - tests/project/test_conda_vendor_1814.py: a conflicting aenum pin appended to the committed file is reported through parse() and compare(), the committed file and an identical duplicate are not, markers are compared once normalised, and --check exits 1 on a conflict in its own output. Closes #1852
Owner
Author
|
Verdict: GOOD TO GO at
Non-blocking nits:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please follow the guide below
You will be asked some questions, please read them carefully and answer honestly
Put an
xinto all the boxes [ ] relevant to your pull request (like that [x])Use Preview tab to see how your pull request will actually look like
Searched for similar pull requests
Followed the coding style (
make pylint,make mypy,make isort)make testpasses, and a test case covers the change. Narrow runs only, listed below.Added a changelog entry under
docs/source/changelog/and regeneratedCHANGELOG.md, if the change is user-visible: N/A — centralised in docs(changelog): shared 1.5.0 changelog — long-lived, merges last (#610, #616, #617, #618, #620) #657What is the purpose of your pull request?
Tick the commit type your subject line carries.
fix— corrects a defectfeat— adds a featureperf— changes performance, not behaviourrefactor— changes neither behaviour nor performancetest— tests onlydocs— documentation onlyci— workflows or build toolingrelease— bumps the version or rolls up a distributionchore— anything elsemarker, so a conflicting duplicate pin passed --check while pip download
-r rejected the file. It now raises Conflicting naming each such pair,
and compare() reports each as a conflict: problem, so --check exits 1.
to the committed file is reported through parse() and compare(), the
committed file and an identical duplicate are not, markers are compared
once normalised, and --check exits 1 on a conflict in its own output.
Closes #1852