Skip to content

ci(release): drop fixed totals and conda-leg installs, smoke-test releases (#1849, #1854, #1855) - #1868

Merged
JarryShaw merged 1 commit into
mainfrom
ci/1849-release-workflow
Oct 17, 2026
Merged

JarryShaw merged 1 commit into
mainfrom
ci/1849-release-workflow

Conversation

@JarryShaw

Copy link
Copy Markdown
Owner

Please follow the guide below

What is the purpose of your pull request?

Tick the commit type your subject line carries.

  • fix — corrects a defect
  • feat — adds a feature
  • perf — changes performance, not behaviour
  • refactor — changes neither behaviour nor performance
  • test — tests only
  • docs — documentation only
  • ci — workflows or build tooling
  • release — bumps the version or rolls up a distribution
  • chore — anything else

  • release_status: the steady-state "Nothing to release" notice no longer
    states PyPI and Anaconda totals, which version_check derives from the
    tag's own tier file.
  • conda-dist and the release conda leg: drop pip install -e .[all], and
    the release leg's pathlib2 typing_extensions. No later step imports
    pcapkit from setup-python's interpreter, and on macos-26-intel the extras
    pull a cryptography with no Intel wheel.
  • Release conda leg: the build step exports host_package, and cron-conda's
    --smoke step runs before anything is uploaded.
  • releasing.rst: re-point the create-release.yml citations the new steps
    shifted.
  • tests/project: a regression test per issue, each failing without its fix.

Closes #1849
Closes #1854
Closes #1855

…eases (#1849, #1854, #1855)

- release_status: the steady-state "Nothing to release" notice no longer
  states PyPI and Anaconda totals, which version_check derives from the
  tag's own tier file.
- conda-dist and the release conda leg: drop `pip install -e .[all]`, and
  the release leg's `pathlib2 typing_extensions`. No later step imports
  pcapkit from setup-python's interpreter, and on macos-26-intel the extras
  pull a cryptography with no Intel wheel.
- Release conda leg: the build step exports `host_package`, and cron-conda's
  `--smoke` step runs before anything is uploaded.
- releasing.rst: re-point the create-release.yml citations the new steps
  shifted.
- tests/project: a regression test per issue, each failing without its fix.

Closes #1849
Closes #1854
Closes #1855
@JarryShaw JarryShaw added ci Pull requests that change CI or workflow configuration (ci: subject prefix) review: running A cross-review is in flight against the current head - no verdict yet labels Oct 16, 2026
@JarryShaw

Copy link
Copy Markdown
Owner Author

Verdict: GOOD TO GO at 5d22e159d. A Sonnet cross-review (author: Opus) read every step after the removed installs in both conda jobs and confirmed:

  • None of those steps needs pcapkit from setup-python's interpreter. pip download needs only pip, conda build and the recipe's import test run in conda's environments, and the version comes from job outputs.
  • --smoke is stdlib-only on its path; it was run under -I -S with no packaging or pcapkit installed.
  • The release smoke step mirrors cron-conda's. host_package is exported where cron does it, and the step sits after the build and before both uploads.
  • The four shifted releasing.rst citations hold the same content. Nothing else cites into the shifted region, and TestDocCitationsResolve passes.
  • All three new tests fail on main for the intended reasons. test_release_gates and the related workflow tests pass.

Unverified until a real run: the conda legs on macos-26-intel. Optional nit: pep.rst:541 still lists the release workflow among those that install .[all].

@JarryShaw JarryShaw added review: good-to-go Cross-review at the current head says ready; CI state is separate and removed review: running A cross-review is in flight against the current head - no verdict yet labels Oct 16, 2026
@JarryShaw JarryShaw moved this to In review in PyPCAPKit Oct 17, 2026
@JarryShaw
JarryShaw merged commit 06e16db into main Oct 17, 2026
56 checks passed
@github-project-automation github-project-automation Bot moved this from In review to Done in PyPCAPKit Oct 17, 2026
@JarryShaw
JarryShaw deleted the ci/1849-release-workflow branch October 17, 2026 02:00
@JarryShaw JarryShaw removed the review: good-to-go Cross-review at the current head says ready; CI state is separate label Oct 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci Pull requests that change CI or workflow configuration (ci: subject prefix)

Projects

Status: Done

1 participant