feat: add bounded region screenshot series - #212
Merged
Merged
Conversation
yashranaway
approved these changes
Sep 22, 2026
yashranaway
left a comment
Collaborator
There was a problem hiding this comment.
Thermo-nuclear + deslop pass.
Clean bounded surface screenshot --by-region @rN, opaque region refs only. Reuses artifact reservation + viewport revalidation + scroll restore, no fork. Protocol-first, SDKs + schema + fixtures in sync. No file >1k due to PR, validation centralized.
Nits (non-blocking):
- HostCore.swift mixes reservation/restore + capture — extract RegionCaptureCoordinator if more region ops land
- AgentRuntime viewport math duplicated — watch drift
Verification strong (protocol/MCP/python/rust + e2e). Ready to merge after other reviewer.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
screenshot --by-region @rNas a bounded, cross-engine screenshot seriesSecurity and failure behavior
Verification
pnpm test: 73/73 protocol tests plus MCP and secure prompt tests passedpnpm test:runtime: passedpnpm test:npm: 41/41 passedcargo test --lockedand strict Clippy passed in Dockerpnpm build: macOS app and website passedpnpm test:e2e:linux: passed with real Chromium and all three region artifacts validatedstart-page-address-hudbefore screenshot coverage; the PR carriesmacos-e2efor the clean runnerCloses #211