Measure the lab review rows once the dialog has settled - #1088
Merged
Merged
Conversation
…dening The review stage widens the sheet and the row grid re-flows from the container width; on a slow runner the 560 px case measured a half-laid-out row and failed on the first attempt. The spec now waits until the surface keeps its width across two frames before it measures.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The 560 px case of the lab-scan review spec (added with #1059) failed on its first attempt in an unrelated PR (#1086) and passed on retry: it measured "unit beside value" and "date beside value" while the sheet was still widening from the picking stage to the review stage and the container-query grid was re-flowing. The spec now waits until the surface keeps the same width across two animation frames before measuring. No product change.