Repository navigation
ParallelProgressReporter: treat an empty callback as "continue" - #7143
Merged
Merged
Conversation
makeObjectTreeFromFolder (and makeObjectTreeFromZip, which forwards its callback) threw std::bad_function_call when called with the default empty callback, because ParallelProgressReporter invoked it unconditionally. Call it through reportProgress, like other progress reporting does. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Fedr
approved these changes
Oct 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
makeObjectTreeFromFolder( folder, dicomOnly )with the default empty callback (andmakeObjectTreeFromZip, which forwards its callback) threwstd::bad_function_call: it wraps the callback inParallelProgressReporter, which invoked it unconditionally fromoperator()and fromupdateTask_on the main thread.Both calls now go through
reportProgress( cb_, progress_ ), so an empty callback means "continue", as elsewhere in the library.makeObjectTreeFromFolderis the only user ofParallelProgressReporter.Test:
MRMesh.ParallelProgressReporterEmptyCallbackreports a task from the reporter's own thread with an empty callback; it fails on master with "bad function call". MRTest passes locally in Release and Debug (531/531).Found while writing the test in #7141, which can drop its
[] ( float ) { return true; }workaround after this.Generated with Claude Code