Repository navigation
reportProgress: take the callback by const reference - #7145
Merged
Merged
Conversation
Passing ProgressCallback by value copied the std::function on every call, which allocates when the callable does not fit the small buffer. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Grantim
approved these changes
Oct 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All four
reportProgressoverloads tookProgressCallbackby value, so every call copied thestd::function. That copy allocates whenever the callable does not fit the small buffer, andreportProgressis called in hot loops and, since #7143, underParallelProgressReporter's mutex.They now take
const ProgressCallback&, matchingsplitProgress. Overload resolution and call sites are unchanged: lambdas and{}still bind to the temporary.subprogresskeeps taking the callback by value, since it moves it into the returned lambda.Checked locally: MRMesh builds with MSVC, no warnings.
🤖 Generated with Claude Code