Repository navigation
parallelFor, forAllRanged: take the progress callback by const reference - #7151
Merged
Merged
Conversation
Avoids copying the std::function on every call made with a named callback. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Grantim
approved these changes
Oct 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
parallelFor( ..., ProgressCallback cb, size_t reportProgressEvery )andBitSetParallel::forAllRanged( ..., ProgressCallback progressCb, size_t reportProgressEveryBit )took the callback by value, so everyParallelFor/BitSetParallelForcall with a named callback copied thestd::function. They now takeconst ProgressCallback&, likereportProgresssince #7145.The
ParallelFor/BitSetParallelFortemplates forward the callback unchanged, so call sites are unaffected: temporaries such assubprogress( cb, a, b )and lambdas bind to the reference.Checked locally: MRMesh builds with MSVC, no warnings.
🤖 Generated with Claude Code